Re: [PATCH mptcp 0/2] mptcp: a couple of fix - almost

From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp 0/2] mptcp: a couple of fix - almost
Date: Fri, 20 Aug 2021 16:02:29 -0700 (PDT)	[thread overview]
Message-ID: <dcc47221-50b4-6c46-320-7231ba4a211f@linux.intel.com> (raw)
In-Reply-To: <cover.1629481305.git.pabeni@redhat.com>

On Fri, 20 Aug 2021, Paolo Abeni wrote:

> This are couple of changes poped-up while investigating
> issues/219. They does not address the mentioned issue,
> but the first one should fix an actual bug, the other
> is more a cleanup, so the target tree is undefined ;)
>
> Paolo Abeni (2):
>  mptcp: fix possible divide by zero
>  mptcp: make the locking tx schema more readable
>
> net/mptcp/protocol.c | 73 +++++++++++++++++++++-----------------------
> 1 file changed, 35 insertions(+), 38 deletions(-)
>
> -- 
> 2.26.3

So far my syzkaller setup hasn't seen the div-by-0 again, but it was 
typically taking days to show up. I'll leave that running over the 
weekend.

Changes look good to me - mptcp_push_release() is now only called from 
places where info->mss_now is non-zero.

Patch 1 for -net, patch 2 for net-next seems appropriate.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel