Re: [OSSTEST PATCH] ap-common: Switch to Linux 6.1 by default on x86 + drop dom0 i386

From: Anthony PERARD <anthony.perard@cloud.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Juergen Gross <jgross@suse.com>
Subject: Re: [OSSTEST PATCH] ap-common: Switch to Linux 6.1 by default on x86 + drop dom0 i386
Date: Tue, 12 Mar 2024 17:19:46 +0000	[thread overview]
Message-ID: <dfe482d8-06d8-4b32-8a28-d6e60b6535dc@perard> (raw)
In-Reply-To: <Ze8_GPiqd9L5SzE8@macbook>

On Mon, Mar 11, 2024 at 06:27:52PM +0100, Roger Pau Monné wrote:
> On Wed, Mar 06, 2024 at 11:47:41AM +0000, Anthony PERARD wrote:
> > Gone, but replaced by a new test-amd64-amd64-*:
> > - test-amd64-i386-libvirt-raw
> > - test-amd64-i386-xl-vhd
> > 
> > Some test-amd64-amd64-* are also changed:
> > - test-amd64-amd64-libvirt-vhd
> > - test-amd64-amd64-qemuu-freebsd11-amd64
> > - test-amd64-amd64-qemuu-freebsd12-amd64
> > - test-amd64-amd64-xl-qcow2
> > + test-amd64-amd64-freebsd11-amd64
> > + test-amd64-amd64-freebsd12-amd64
> > + test-amd64-amd64-libvirt-qcow2
> > + test-amd64-amd64-libvirt-raw
> > + test-amd64-amd64-xl-vhd
> 
> Is this purely a name change, or there's some kind of functional
> change?

For test-amd64-amd64-qemuu-freebsd1{1,2}-amd64, it looks like the
"-qemuu" is a bug. The freebsd jobs shouldn't have used $qemuu_suffix,
as it doesn't use $qemuu_runvar. So I'm guessing $qemuu_suffix was just
the value left from a previous call of test_matrix_do_one() with
dom0arch==i386. The new name is already used by "linux-linus" branch.

As for the few changes in {xl,libvirt}-{raw,vhd,qcow2} tests, this is
because of
- f536e834f673 ("make-flight: Trim the matrix of disk format flights")
- 5c70735f177f ("fmtarches: Use dom0arches, not hardcoded arch list")
   > It's not ideal because it means tests jumping about across arches and
   > might let regressions go through but it's better than just dropping
   > them, and doing a better approach is complex.

So, for those, yes, it's different tests. It adds one "-raw" test, and
otherwise changes the toolstack used for the two other disk formats.

> I'm mostly worried whether this could lead to regressions getting in
> as osstest would detect those jobs as new instead of inheriting from
> the previous jobs.  Also the "History for test ..." won't link to jobs
> prior to the rename?

Well, those tests are already in the "linux-linus" branch and the new
"linux-6.1" branch, so we can already check manually if there's a
regression or not. So if they pass in linux-6.1, regression will be
detected, at least in the linux branch.

The rename of the freebsd jobs is unfortunate, but at least, it's going
to be the correct name, instead of having a spurious "-qemuu" suffix.

As for "history of tests " pages, no I don't think we can easly link to
to the previous job name. But that only apply to both freebsd* jobs.

We could keep the -qemuu in freebsd* jobs even if it's misleading to
someone who know what it should mean, that would keep the job name to
all branches and rename it in "linux-linus" branch. I don't know which
one is better.

> I guess I'm confused about what causes the qemuu to be dropped from
> the job names above.

It just shell script having variable been global by default.

Cheers,

-- 
Anthony PERARD