From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Y8Eg=NK=saout.de=dm-crypt-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 50EA5C4338F
	for <dm-crypt@archiver.kernel.org>; Thu, 19 Aug 2021 22:21:26 +0000 (UTC)
Received: from mail.server123.net (mail.server123.net [78.46.64.186])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id E4D6B61028
	for <dm-crypt@archiver.kernel.org>; Thu, 19 Aug 2021 22:21:25 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E4D6B61028
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=corelight.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=saout.de
X-Virus-Scanned: amavisd-new at saout.de
Authentication-Results: mail.server123.net (amavisd-new);
	dkim=pass (2048-bit key) header.d=corelight-com.20150623.gappssmtp.com
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::329; helo=mail-wm1-x329.google.com; envelope-from=arne.welzel@corelight.com; receiver=<UNKNOWN> 
Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by mail.server123.net (Postfix) with ESMTPS
	for <dm-crypt@saout.de>; Thu, 12 Aug 2021 21:47:43 +0200 (CEST)
Received: by mail-wm1-x329.google.com with SMTP id l7-20020a1c2507000000b002e6be5d86b3so1948381wml.3
        for <dm-crypt@saout.de>; Thu, 12 Aug 2021 12:47:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=corelight-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:in-reply-to:message-id:references
         :mime-version;
        bh=4yVVGSubGIAUjMvYqinX3dOobTEZJ/iEvN/MAz4QKJE=;
        b=J5zUD5K9/S3w9L8/02igDAAnpzuUJW+BoTFLKLNXH+gfir/CrxZPaQ1pXZtSq9SD3H
         yiO0wNdE2EnP+pJNbnQ2onVZQqKdaXxjxEItdGE5PsgItD3/dNy89VNuQIBg95FUcuyQ
         PkzOwlrwBeL6PAPLZaIRc5MXWY/N/8fqnbFZIt/IaHWAFCBhwzVlJRjtbQYYzYNOGwdI
         XZSevYl73UJCEMkok1H+9PetME5o0wwvYXiIKZWwpmDq6gTe8bGbglxH9TXrzT1cNdSC
         IiK4wia9Ny2OHuA34N1xa+ssAAzb5a8VbE7qa/tqXNZkR4B9meaXM08oMJwigCsQbbCJ
         O50w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id
         :references:mime-version;
        bh=4yVVGSubGIAUjMvYqinX3dOobTEZJ/iEvN/MAz4QKJE=;
        b=bthCZHCD7rT3fYDieBWYgZFd6tQPHMawK0Ub6kpm3h0z5CNrl7SRyBxVcChJrHXu2A
         WoCrNQsaX89m2P1a7Hy/xns258kqcM8yavi2gx9l2tMwxNamR5+BQGPVwFgZdzyPe574
         lFGnH/kO7ECpZYkM8taEZwEGojlZP3bKOEpt9zsTKkBS/I8lGuQXD4znN+xovQbHVFbJ
         Nvq74TfGFNIkmdwELcRdkgoAI9qP0nbo1NE3Rpf7cZPvrwBDGlgLsjG0AaV4IYo/6nux
         jCmLafSnj+XQ/TcuDx/JQr8RjolCCcT2CEzDm1Mu2X8dPJ64QaPj5j0DJmJBJL6fp7Mm
         FtVA==
X-Gm-Message-State: AOAM532VCwaMao5DlgsXcZ0yvzAvtUaxChjTbVxwcjJE+p7a4ag5jERO
	YBThQse92NBu0+X8LppHjhRnew==
X-Google-Smtp-Source: ABdhPJxNVjkpAjnzz5UjbfS4wJEc64a2YdkvYd2C7720q3Wixp8ZPHcyKINHebBS9SpwNcmn8cLfKg==
X-Received: by 2002:a05:600c:4f0f:: with SMTP id l15mr223608wmq.106.1628797662888;
        Thu, 12 Aug 2021 12:47:42 -0700 (PDT)
Received: from tinkyx280 ([2a02:8108:8440:5da4:6c41:9e8b:2e76:271])
        by smtp.gmail.com with ESMTPSA id k6sm3977149wrm.10.2021.08.12.12.47.42
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 12 Aug 2021 12:47:42 -0700 (PDT)
Date: Thu, 12 Aug 2021 21:47:41 +0200 (CEST)
From: Arne Welzel <arne.welzel@corelight.com>
To: Mikulas Patocka <mpatocka@redhat.com>
In-Reply-To: <alpine.LRH.2.02.2108101420250.26585@file01.intranet.prod.int.rdu2.redhat.com>
Message-ID: <39101295-ed12-33c1-ce1-86a649f5582@corelight.com>
References: <20210808134205.1981531-1-arne.welzel@corelight.com> <alpine.LRH.2.02.2108101420250.26585@file01.intranet.prod.int.rdu2.redhat.com>
MIME-Version: 1.0
X-MailFrom: arne.welzel@corelight.com
X-Mailman-Rule-Hits: nonmember-moderation
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-dm-crypt.saout.de-0
Message-ID-Hash: PE5LZDYHROMI6HVEXZOTWFCTOK7I3R6Z
X-Message-ID-Hash: PE5LZDYHROMI6HVEXZOTWFCTOK7I3R6Z
X-Mailman-Approved-At: Fri, 20 Aug 2021 00:07:44 +0200
CC: dm-devel@redhat.com, dm-crypt@saout.de, snitzer@redhat.com, agk@redhat.com, DJ Gregor <dj@corelight.com>
X-Mailman-Version: 3.3.2
Precedence: list
Subject: [dm-crypt] Re: [PATCH] dm crypt: Avoid percpu_counter spinlock contention in crypt_page_alloc()
List-Id: <dm-crypt.saout.de>
List-Help: <mailto:dm-crypt-request@saout.de?subject=help>
List-Post: <mailto:dm-crypt@saout.de>
List-Subscribe: <mailto:dm-crypt-join@saout.de>
List-Unsubscribe: <mailto:dm-crypt-leave@saout.de>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Mikulas,

On Tue, 10 Aug 2021, Mikulas Patocka wrote:

> Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
>

thank you for the review. After looking at the submitted patch again,
seems more proper to use >= as the condition:

> > + if (unlikely(percpu_counter_read_positive(&cc->n_allocated_pages) > dm_crypt_pages_per_client) &&
                                                                        ^^
                                                                        >=
Would it be okay if I resend the patch with this changed and add your
Reviewed-by still? Would also fix some wording in the description and
dedent the perf report output somewhat.

Thanks,
   Arne

_______________________________________________
dm-crypt mailing list -- dm-crypt@saout.de
To unsubscribe send an email to dm-crypt-leave@saout.de