From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C67F8C4338F for ; Thu, 12 Aug 2021 20:43:00 +0000 (UTC) Received: from mail.server123.net (mail.server123.net [78.46.64.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50B73610CF for ; Thu, 12 Aug 2021 20:43:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50B73610CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=saout.de X-Virus-Scanned: amavisd-new at saout.de Authentication-Results: mail.server123.net (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=mpatocka@redhat.com; receiver= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.server123.net (Postfix) with ESMTPS for ; Thu, 12 Aug 2021 22:40:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628800802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pKkUdjyXStr5rvNw7PUrJR3lIidMroos7MBubBkejUk=; b=cJO884G8LVUyH3m6DoxJ0ZTBGjUbpjgEpt+TPx3Bm4YhnLcK93n5hJRCpf4NWDhJeW+PNI 4LEB6MexL3mo1DGML5eQGenHWMgxlf6sSbEeK8xvNPEv9V6N+/GlGvc115lK8FNwQK1ELm gzL/NXl6RVZeMDWFBE966bwXpAs+dWU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-B7MfawKcNiSVPnfIHss34g-1; Thu, 12 Aug 2021 16:38:05 -0400 X-MC-Unique: B7MfawKcNiSVPnfIHss34g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D9A51008061; Thu, 12 Aug 2021 20:38:04 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BBBA85C3DF; Thu, 12 Aug 2021 20:37:56 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id 17CKbufA014004; Thu, 12 Aug 2021 16:37:56 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id 17CKbtss014001; Thu, 12 Aug 2021 16:37:55 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Thu, 12 Aug 2021 16:37:55 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Arne Welzel In-Reply-To: <39101295-ed12-33c1-ce1-86a649f5582@corelight.com> Message-ID: References: <20210808134205.1981531-1-arne.welzel@corelight.com> <39101295-ed12-33c1-ce1-86a649f5582@corelight.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mpatocka@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: TO3VEKR6NLOJ37VILUNQIM5B5ZU4O4M6 X-Message-ID-Hash: TO3VEKR6NLOJ37VILUNQIM5B5ZU4O4M6 X-MailFrom: mpatocka@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-dm-crypt.saout.de-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: dm-devel@redhat.com, dm-crypt@saout.de, snitzer@redhat.com, agk@redhat.com, DJ Gregor X-Mailman-Version: 3.3.2 Precedence: list Subject: [dm-crypt] Re: [PATCH] dm crypt: Avoid percpu_counter spinlock contention in crypt_page_alloc() List-Id: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 12 Aug 2021, Arne Welzel wrote: > Mikulas, > > On Tue, 10 Aug 2021, Mikulas Patocka wrote: > > > Reviewed-by: Mikulas Patocka > > > > thank you for the review. After looking at the submitted patch again, > seems more proper to use >= as the condition: > > > > + if (unlikely(percpu_counter_read_positive(&cc->n_allocated_pages) > dm_crypt_pages_per_client) && > ^^ > >= > Would it be okay if I resend the patch with this changed and add your > Reviewed-by still? Would also fix some wording in the description and > dedent the perf report output somewhat. > > Thanks, > Arne OK - you can resend the patch with my "Reviewed-by". Mikulas _______________________________________________ dm-crypt mailing list -- dm-crypt@saout.de To unsubscribe send an email to dm-crypt-leave@saout.de