From: Martin Wilck <mwilck@suse.com>
To: lixiaokeng <lixiaokeng@huawei.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>,
dm-devel mailing list <dm-devel@redhat.com>
Cc: linfeilong <linfeilong@huawei.com>,
"liuzhiqiang \(I\)" <liuzhiqiang26@huawei.com>
Subject: Re: [dm-devel] [PATCH] libmultipath: fix compile error with glibc-2.34+
Date: Thu, 12 Aug 2021 13:17:00 +0200 [thread overview]
Message-ID: <04731456fed935e1167d1f48febf2a21df8cb586.camel@suse.com> (raw)
In-Reply-To: <30798fdf-a112-ff8c-73ac-a37a87b99bd0@huawei.com>
Hello Lixiaokeng,
On Mi, 2021-08-11 at 21:11 +0800, lixiaokeng wrote:
> There is an error when complie with glibc-2.34:
> comparison of integer expressions of different signedness:
> 'size_t' {aka 'long unsigned int'} and 'long int'
> [-Werror=sign-compare]
>
> The reason is that PTHREAD_STACK_MIN may be defined
> long int which is signed in glibc-2.34+. Explicitly assign
> it to the size_t variable to fix it.
>
> Signed-off-by: Lixiaokeng <lixiaokeng@huawei.com>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Thanks! Ben had already submitted a patch for this in
https://listman.redhat.com/archives/dm-devel/2021-July/msg00159.html.
Ben's patch handles the error case (-1) more correctly.
Regards
Martin
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-08-12 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 13:11 [dm-devel] [PATCH] libmultipath: fix compile error with glibc-2.34+ lixiaokeng
2021-08-12 11:17 ` Martin Wilck [this message]
2021-08-12 12:45 ` lixiaokeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04731456fed935e1167d1f48febf2a21df8cb586.camel@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=linfeilong@huawei.com \
--cc=liuzhiqiang26@huawei.com \
--cc=lixiaokeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).