From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 01/14] dm: use bio_uninit instead of bio_disassociate_blkg Date: Wed, 8 Jul 2020 10:02:54 -0400 Message-ID: <20200708140254.GA7539@redhat.com> References: <20200627073159.2447325-1-hch@lst.de> <20200627073159.2447325-2-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200627073159.2447325-2-hch-jcswGhMUV9g@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig Cc: Jens Axboe , Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Li Zefan , Johannes Weiner , Dennis Zhou List-Id: dm-devel.ids On Sat, Jun 27 2020 at 3:31am -0400, Christoph Hellwig wrote: > bio_uninit is the proper API to clean up a BIO that has been allocated > on stack or inside a structure that doesn't come from the BIO allocator. > Switch dm to use that instead of bio_disassociate_blkg, which really is > an implementation detail. Note that the bio_uninit calls are also moved > to the two callers of __send_empty_flush, so that they better pair with > the bio_init calls used to initialize them. > > Signed-off-by: Christoph Hellwig I've picked this up as a fix for 5.8 Thanks, Mike