dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Cc: Song Liu <song-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
	Minchan Kim <minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org,
	linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Johannes Thumshirn
	<johannes.thumshirn-Sjgp3cTcYWE@public.gmane.org>
Subject: [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE
Date: Thu, 10 Sep 2020 16:48:23 +0200	[thread overview]
Message-ID: <20200910144833.742260-4-hch@lst.de> (raw)
In-Reply-To: <20200910144833.742260-1-hch-jcswGhMUV9g@public.gmane.org>

This case isn't ever used.

Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn-Sjgp3cTcYWE@public.gmane.org>
---
 drivers/block/drbd/drbd_req.c | 4 ----
 include/linux/drbd.h          | 1 -
 2 files changed, 5 deletions(-)

diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index 5c975af9c15fb8..481bc34fcf386a 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -901,13 +901,9 @@ static bool drbd_may_do_local_read(struct drbd_device *device, sector_t sector,
 static bool remote_due_to_read_balancing(struct drbd_device *device, sector_t sector,
 		enum drbd_read_balancing rbm)
 {
-	struct backing_dev_info *bdi;
 	int stripe_shift;
 
 	switch (rbm) {
-	case RB_CONGESTED_REMOTE:
-		bdi = device->ldev->backing_bdev->bd_disk->queue->backing_dev_info;
-		return bdi_read_congested(bdi);
 	case RB_LEAST_PENDING:
 		return atomic_read(&device->local_cnt) >
 			atomic_read(&device->ap_pending_cnt) + atomic_read(&device->rs_pending_cnt);
diff --git a/include/linux/drbd.h b/include/linux/drbd.h
index 5755537b51b114..6a8286132751df 100644
--- a/include/linux/drbd.h
+++ b/include/linux/drbd.h
@@ -94,7 +94,6 @@ enum drbd_read_balancing {
 	RB_PREFER_REMOTE,
 	RB_ROUND_ROBIN,
 	RB_LEAST_PENDING,
-	RB_CONGESTED_REMOTE,
 	RB_32K_STRIPING,
 	RB_64K_STRIPING,
 	RB_128K_STRIPING,
-- 
2.28.0

  parent reply	other threads:[~2020-09-10 14:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 14:48 bdi cleanups v4 Christoph Hellwig
     [not found] ` <20200910144833.742260-1-hch-jcswGhMUV9g@public.gmane.org>
2020-09-10 14:48   ` [PATCH 01/12] fs: remove the unused SB_I_MULTIROOT flag Christoph Hellwig
2020-09-17  9:41     ` Jan Kara
2020-09-10 14:48   ` [PATCH 02/12] drbd: remove dead code in device_to_statistics Christoph Hellwig
     [not found]     ` <20200910144833.742260-3-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17  9:46       ` Jan Kara
2020-09-10 14:48   ` Christoph Hellwig [this message]
2020-09-17  9:55     ` [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE Jan Kara
     [not found]       ` <20200917095507.GJ7347-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2020-09-19  6:58         ` Christoph Hellwig
2020-09-10 14:48   ` [PATCH 04/12] bdi: initialize ->ra_pages and ->io_pages in bdi_init Christoph Hellwig
     [not found]     ` <20200910144833.742260-5-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 10:04       ` Jan Kara
2020-09-19  7:01         ` Christoph Hellwig
2020-09-10 14:48   ` [PATCH 07/12] bdi: remove BDI_CAP_CGROUP_WRITEBACK Christoph Hellwig
     [not found]     ` <20200910144833.742260-8-hch-jcswGhMUV9g@public.gmane.org>
2020-09-16  9:28       ` David Sterba
2020-09-17  9:36       ` Jan Kara
2020-09-10 14:48   ` [PATCH 09/12] mm: use SWP_SYNCHRONOUS_IO more intelligently Christoph Hellwig
2020-09-17  9:06     ` Jan Kara
2020-09-10 14:48   ` [PATCH 11/12] bdi: invert BDI_CAP_NO_ACCT_WB Christoph Hellwig
     [not found]     ` <20200910144833.742260-12-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17  9:27       ` Jan Kara
2020-09-10 14:48   ` [PATCH 12/12] bdi: replace BDI_CAP_NO_{WRITEBACK, ACCT_DIRTY} with a single flag Christoph Hellwig
     [not found]     ` <20200910144833.742260-13-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17  9:31       ` Jan Kara
2020-09-10 14:48 ` [PATCH 05/12] md: update the optimal I/O size on reshape Christoph Hellwig
2020-09-12  6:17   ` Song Liu
2020-09-10 14:48 ` [PATCH 06/12] block: lift setting the readahead size into the block layer Christoph Hellwig
     [not found]   ` <20200910144833.742260-7-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17 10:35     ` Jan Kara
2020-09-19  7:31       ` Christoph Hellwig
2020-09-10 14:48 ` [PATCH 08/12] bdi: remove BDI_CAP_SYNCHRONOUS_IO Christoph Hellwig
     [not found]   ` <20200910144833.742260-9-hch-jcswGhMUV9g@public.gmane.org>
2020-09-17  9:36     ` Jan Kara
2020-09-10 14:48 ` [PATCH 10/12] bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag Christoph Hellwig
2020-09-17  9:25   ` Jan Kara
     [not found]     ` <20200917092524.GC7347-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2020-09-19  6:51       ` Christoph Hellwig
2020-09-15 15:18 bdi cleanups v5 Christoph Hellwig
     [not found] ` <20200915151829.1767176-1-hch-jcswGhMUV9g@public.gmane.org>
2020-09-15 15:18   ` [PATCH 03/12] drbd: remove RB_CONGESTED_REMOTE Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910144833.742260-4-hch@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=johannes.thumshirn-Sjgp3cTcYWE@public.gmane.org \
    --cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=richard-/L3Ra7n9ekc@public.gmane.org \
    --cc=song-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).