From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Justin Sanders <justin@coraid.com>,
Minchan Kim <minchan@kernel.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
cgroups@vger.kernel.org, linux-bcache@vger.kernel.org,
Coly Li <colyli@suse.de>,
linux-block@vger.kernel.org, Song Liu <song@kernel.org>,
dm-devel@redhat.com, linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
drbd-dev@tron.linbit.com, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/13] block: lift setting the readahead size into the block layer
Date: Thu, 24 Sep 2020 11:03:19 -0400 [thread overview]
Message-ID: <20200924150318.GE13849@redhat.com> (raw)
In-Reply-To: <20200924065140.726436-8-hch@lst.de>
On Thu, Sep 24 2020 at 2:51am -0400,
Christoph Hellwig <hch@lst.de> wrote:
> Drivers shouldn't really mess with the readahead size, as that is a VM
> concept. Instead set it based on the optimal I/O size by lifting the
> algorithm from the md driver when registering the disk. Also set
> bdi->io_pages there as well by applying the same scheme based on
> max_sectors. To ensure the limits work well for stacking drivers a
> new helper is added to update the readahead limits from the block
> limits, which is also called from disk_stack_limits.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Coly Li <colyli@suse.de>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Thanks for adding blk_queue_update_readahead()
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2020-09-24 15:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 6:51 bdi cleanups v7 Christoph Hellwig
2020-09-24 6:51 ` [PATCH 01/13] fs: remove the unused SB_I_MULTIROOT flag Christoph Hellwig
[not found] ` <20200924065140.726436-1-hch-jcswGhMUV9g@public.gmane.org>
2020-09-24 6:51 ` [PATCH 02/13] drbd: remove dead code in device_to_statistics Christoph Hellwig
2020-09-24 6:51 ` [PATCH 08/13] bdi: remove BDI_CAP_CGROUP_WRITEBACK Christoph Hellwig
2020-09-24 6:51 ` [PATCH 12/13] bdi: invert BDI_CAP_NO_ACCT_WB Christoph Hellwig
2020-09-24 6:51 ` [PATCH 03/13] bcache: inherit the optimal I/O size Christoph Hellwig
[not found] ` <20200924065140.726436-4-hch-jcswGhMUV9g@public.gmane.org>
2020-09-24 15:49 ` Martin K. Petersen
2020-09-24 6:51 ` [PATCH 04/13] aoe: set an " Christoph Hellwig
[not found] ` <20200924065140.726436-5-hch-jcswGhMUV9g@public.gmane.org>
2020-09-24 15:51 ` Martin K. Petersen
2020-09-24 6:51 ` [PATCH 05/13] bdi: initialize ->ra_pages and ->io_pages in bdi_init Christoph Hellwig
2020-09-24 6:51 ` [PATCH 06/13] md: update the optimal I/O size on reshape Christoph Hellwig
[not found] ` <20200924065140.726436-7-hch-jcswGhMUV9g@public.gmane.org>
2020-09-24 15:53 ` Martin K. Petersen
2020-09-24 6:51 ` [PATCH 07/13] block: lift setting the readahead size into the block layer Christoph Hellwig
2020-09-24 15:03 ` Mike Snitzer [this message]
[not found] ` <20200924065140.726436-8-hch-jcswGhMUV9g@public.gmane.org>
2020-09-24 14:53 ` Jan Kara
2020-09-24 15:57 ` Martin K. Petersen
2020-09-24 6:51 ` [PATCH 09/13] bdi: remove BDI_CAP_SYNCHRONOUS_IO Christoph Hellwig
2020-09-24 6:51 ` [PATCH 10/13] mm: use SWP_SYNCHRONOUS_IO more intelligently Christoph Hellwig
2020-09-24 6:51 ` [PATCH 11/13] bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag Christoph Hellwig
2020-09-24 6:51 ` [PATCH 13/13] bdi: replace BDI_CAP_NO_{WRITEBACK,ACCT_DIRTY} with a single flag Christoph Hellwig
2020-09-24 19:44 ` bdi cleanups v7 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-09-21 8:07 bdi cleanups v6 Christoph Hellwig
2020-09-21 8:07 ` [PATCH 07/13] block: lift setting the readahead size into the block layer Christoph Hellwig
2020-09-22 9:13 ` Jan Kara
2020-09-22 9:51 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924150318.GE13849@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@tron.linbit.com \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=johannes.thumshirn@wdc.com \
--cc=justin@coraid.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=richard@nod.at \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).