From: Eric Biggers <ebiggers@kernel.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Satya Tangirala <satyat@google.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH 2/3] dm: add support for passing through inline crypto support
Date: Thu, 24 Sep 2020 08:45:50 -0700 [thread overview]
Message-ID: <20200924154550.GA1266@sol.localdomain> (raw)
In-Reply-To: <20200924134649.GB13849@redhat.com>
On Thu, Sep 24, 2020 at 09:46:49AM -0400, Mike Snitzer wrote:
> > > Can you help me better understand the expected consumer of this code?
> > > If you have something _real_ please be explicit. It makes justifying
> > > supporting niche code like this more tolerable.
> >
> > So the motivation for this code was that Android currently uses a device
> > mapper target on top of a phone's disk for user data. On many phones,
> > that disk has inline encryption support, and it'd be great to be able to
> > make use of that. The DM device configuration isn't changed at runtime.
>
> OK, which device mapper target is used?
There are several device-mapper targets that Android can require for the
"userdata" partition -- potentially in a stack of more than one:
dm-linear: required for Dynamic System Updates
(https://developer.android.com/topic/dsu)
dm-bow: required for User Data Checkpoints on ext4
(https://source.android.com/devices/tech/ota/user-data-checkpoint)
(https://patchwork.kernel.org/patch/10838743/)
dm-default-key: required for metadata encryption
(https://source.android.com/security/encryption/metadata)
We're already carrying this patchset in the Android common kernels since late
last year, as it's required for inline encryption to work when any of the above
is used. So this is something that is needed and is already being used.
Now, you don't have to "count" dm-bow and dm-default-key since they aren't
upstream; that leaves dm-linear. But hopefully the others at least show that
architecturally, dm-linear is just the initial use case, and this patchset also
makes it easy to pass through inline crypto on any other target that can support
it (basically, anything that doesn't change the data itself as it goes through).
- Eric
next prev parent reply other threads:[~2020-09-24 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 23:44 [PATCH 0/3] add support for inline encryption to device mapper Satya Tangirala
2020-09-09 23:44 ` [PATCH 1/3] block: keyslot-manager: Introduce passthrough keyslot manager Satya Tangirala
2020-09-22 0:27 ` Eric Biggers
2020-09-09 23:44 ` [PATCH 2/3] dm: add support for passing through inline crypto support Satya Tangirala
2020-09-22 0:32 ` Eric Biggers
2020-09-24 1:14 ` Mike Snitzer
2020-09-24 7:17 ` Satya Tangirala
2020-09-24 13:46 ` Mike Snitzer
2020-09-24 15:45 ` Eric Biggers [this message]
2020-09-24 16:16 ` Mike Snitzer
2020-09-24 16:57 ` Eric Biggers
2020-09-24 1:21 ` Mike Snitzer
2020-09-24 7:38 ` Satya Tangirala
2020-09-24 14:23 ` Mike Snitzer
2020-10-15 22:05 ` [dm-devel] " Satya Tangirala
2020-09-24 7:48 ` Satya Tangirala
2020-09-24 13:40 ` Mike Snitzer
2020-10-15 21:55 ` [dm-devel] " Satya Tangirala
2020-09-09 23:44 ` [PATCH 3/3] dm: enable may_passthrough_inline_crypto on some targets Satya Tangirala
2020-09-22 0:49 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924154550.GA1266@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=satyat@google.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).