From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Marzinski Subject: Re: [PATCH v2 20/21] mpathpersist: remove logsink and udev Date: Fri, 25 Sep 2020 18:56:03 -0500 Message-ID: <20200925235603.GH3384@octiron.msp.redhat.com> References: <20200924133716.14120-1-mwilck@suse.com> <20200924133716.14120-21-mwilck@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200924133716.14120-21-mwilck@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Content-Disposition: inline To: mwilck@suse.com Cc: dm-devel@redhat.com List-Id: dm-devel.ids On Thu, Sep 24, 2020 at 03:37:15PM +0200, mwilck@suse.com wrote: > From: Martin Wilck > > We can use libmultipath's internal symbols now. The libmultipath > initialization is taken care of by libmpathpersist_init(). > Reviewed-by: Benjamin Marzinski > Signed-off-by: Martin Wilck > --- > mpathpersist/main.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mpathpersist/main.c b/mpathpersist/main.c > index 278e48f..3c2e657 100644 > --- a/mpathpersist/main.c > +++ b/mpathpersist/main.c > @@ -42,13 +42,10 @@ void * mpath_alloc_prin_response(int prin_sa); > void mpath_print_transport_id(struct prin_fulldescr *fdesc); > int construct_transportid(const char * inp, struct transportid transid[], int num_transportids); > > -int logsink; > - > void rcu_register_thread_memb(void) {} > > void rcu_unregister_thread_memb(void) {} > > -struct udev *udev; > > static int verbose, loglevel, noisy; > > @@ -641,16 +638,13 @@ int main(int argc, char *argv[]) > exit (1); > } > > - udev = udev_new(); > if (libmpathpersist_init()) { > - udev_unref(udev); > exit(1); > } > > ret = handle_args(argc, argv, 0); > > libmpathpersist_exit(); > - udev_unref(udev); > > return (ret >= 0) ? ret : MPATH_PR_OTHER; > } > -- > 2.28.0