From: Benjamin Marzinski <bmarzins@redhat.com>
To: mwilck@suse.com
Cc: lixiaokeng@huawei.com, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH v2 27/29] multipathd: common code for "-k" and command args
Date: Mon, 19 Oct 2020 16:51:51 -0500 [thread overview]
Message-ID: <20201019215151.GI3384@octiron.msp.redhat.com> (raw)
In-Reply-To: <20201016104501.8700-28-mwilck@suse.com>
On Fri, Oct 16, 2020 at 12:44:59PM +0200, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> 'multipathd -k"cmd"' and 'multipath cmd' are the same thing.
> Treat it with common code.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> multipathd/main.c | 37 +++++++++++++++++++------------------
> 1 file changed, 19 insertions(+), 18 deletions(-)
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 725a10b..0cf8a26 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -3303,6 +3303,8 @@ main (int argc, char *argv[])
> int err;
> int foreground = 0;
> struct config *conf;
> + char *opt_k_arg = NULL;
> + bool opt_k = false;
>
> ANNOTATE_BENIGN_RACE_SIZED(&multipath_conf, sizeof(multipath_conf),
> "Manipulated through RCU");
> @@ -3350,16 +3352,9 @@ main (int argc, char *argv[])
> logsink = LOGSINK_STDERR_WITHOUT_TIME;
> break;
> case 'k':
> - logsink = 0;
> - conf = load_config(DEFAULT_CONFIGFILE);
> - if (!conf)
> - exit(1);
> - if (verbosity)
> - libmp_verbosity = verbosity;
> - uxsock_timeout = conf->uxsock_timeout;
> - err = uxclnt(optarg, uxsock_timeout + 100);
> - free_config(conf);
> - return err;
> + opt_k = true;
> + opt_k_arg = optarg;
> + break;
> case 'B':
> bindings_read_only = 1;
> break;
> @@ -3375,7 +3370,7 @@ main (int argc, char *argv[])
> exit(1);
> }
> }
> - if (optind < argc) {
> + if (opt_k || optind < argc) {
> char cmd[CMDSIZE];
> char * s = cmd;
> char * c = s;
> @@ -3390,14 +3385,20 @@ main (int argc, char *argv[])
> libmp_verbosity = verbosity;
> uxsock_timeout = conf->uxsock_timeout;
> memset(cmd, 0x0, CMDSIZE);
> - while (optind < argc) {
> - if (strchr(argv[optind], ' '))
> - c += snprintf(c, s + CMDSIZE - c, "\"%s\" ", argv[optind]);
> - else
> - c += snprintf(c, s + CMDSIZE - c, "%s ", argv[optind]);
> - optind++;
> + if (opt_k)
> + s = opt_k_arg;
> + else {
> + while (optind < argc) {
> + if (strchr(argv[optind], ' '))
> + c += snprintf(c, s + CMDSIZE - c,
> + "\"%s\" ", argv[optind]);
> + else
> + c += snprintf(c, s + CMDSIZE - c,
> + "%s ", argv[optind]);
> + optind++;
> + }
> + c += snprintf(c, s + CMDSIZE - c, "\n");
combining these two methods makes is obvious that adding the newline to
the cmd buffer is unnecessary. But since your patch didn't add it, and
it doesn't hurt anything
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> }
> - c += snprintf(c, s + CMDSIZE - c, "\n");
> err = uxclnt(s, uxsock_timeout + 100);
> free_config(conf);
> return err;
> --
> 2.28.0
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2020-10-19 21:52 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 10:44 [dm-devel] [PATCH v2 00/29] libmultipath: improve cleanup on exit mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 01/29] multipathd: uxlsnr: avoid deadlock " mwilck
2020-10-20 19:04 ` Benjamin Marzinski
2020-10-16 10:44 ` [dm-devel] [PATCH v2 02/29] multipathd: Fix liburcu memory leak mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 03/29] multipathd: move handling of io_err_stat_attr into libmultipath mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 04/29] multipathd: move vecs desctruction into cleanup function mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 05/29] multipathd: make some globals static mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 06/29] multipathd: move threads destruction into separate function mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 07/29] multipathd: move conf " mwilck
2020-10-19 18:56 ` Benjamin Marzinski
2020-10-16 10:44 ` [dm-devel] [PATCH v2 08/29] multipathd: move pid " mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 09/29] multipathd: close pidfile on exit mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 10/29] multipathd: add helper for systemd notification at exit mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 11/29] multipathd: child(): call cleanups in failure case, too mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 12/29] multipathd: unwatch_all_dmevents: check if waiter is initialized mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 13/29] multipathd: print error message if config can't be loaded mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 14/29] libmultipath: add libmp_dm_exit() mwilck
2020-10-19 19:07 ` Benjamin Marzinski
2020-10-16 10:44 ` [dm-devel] [PATCH v2 15/29] multipathd: fixup libdm deinitialization mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 16/29] libmultipath: log_thread_stop(): check if logarea is initialized mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 17/29] multipathd: add cleanup_child() exit handler mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 18/29] libmultipath: fix log_thread startup and teardown mwilck
2020-10-19 20:00 ` Benjamin Marzinski
2020-10-26 13:58 ` Martin Wilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 19/29] multipathd: move cleanup_{prio, checkers, foreign} to libmultipath_exit mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 20/29] multipath: use atexit() for cleanup handlers mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 21/29] mpathpersist: " mwilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 22/29] multipath: fix leaks in check_path_valid() mwilck
2020-12-16 17:34 ` Martin Wilck
2020-12-16 22:41 ` Benjamin Marzinski
2020-10-16 10:44 ` [dm-devel] [PATCH v2 23/29] multipath-tools: mpath-tools.supp: file with valgrind suppressions mwilck
2020-10-19 20:01 ` Benjamin Marzinski
2020-10-16 10:44 ` [dm-devel] [PATCH v2 24/29] libmultipath: use libmp_verbosity to track verbosity mwilck
2020-10-19 20:38 ` Benjamin Marzinski
2020-10-26 14:47 ` Martin Wilck
2020-10-16 10:44 ` [dm-devel] [PATCH v2 25/29] libmultipath: introduce symbolic values for logsink mwilck
2020-10-16 20:13 ` Benjamin Marzinski
2020-10-16 10:44 ` [dm-devel] [PATCH v2 26/29] libmultipath: simplify dlog() mwilck
2020-10-19 21:07 ` Benjamin Marzinski
2020-10-16 10:44 ` [dm-devel] [PATCH v2 27/29] multipathd: common code for "-k" and command args mwilck
2020-10-19 21:51 ` Benjamin Marzinski [this message]
2020-10-16 10:45 ` [dm-devel] [PATCH v2 28/29] multipathd: sanitize uxsock_listen() mwilck
2020-10-19 23:33 ` Benjamin Marzinski
2020-10-26 13:54 ` Martin Wilck
2020-10-16 10:45 ` [dm-devel] [PATCH v2 29/29] libmultipath: fix race between log_safe and log_thread_stop() mwilck
2020-10-20 2:20 ` Benjamin Marzinski
2020-10-26 16:22 ` Martin Wilck
2020-10-26 17:24 ` Martin Wilck
2020-11-03 0:11 ` Benjamin Marzinski
2020-11-04 12:36 ` Martin Wilck
2020-11-04 15:46 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019215151.GI3384@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
--cc=lixiaokeng@huawei.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).