From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474A1C5519F for ; Wed, 25 Nov 2020 14:56:38 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70C2720857 for ; Wed, 25 Nov 2020 14:56:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70C2720857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-589-itWhjtMPMd6KBKtlzEvdhw-1; Wed, 25 Nov 2020 09:56:34 -0500 X-MC-Unique: itWhjtMPMd6KBKtlzEvdhw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 314B2803F62; Wed, 25 Nov 2020 14:56:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 942931001281; Wed, 25 Nov 2020 14:56:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 264D14E58F; Wed, 25 Nov 2020 14:56:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0APCVftV000599 for ; Wed, 25 Nov 2020 07:31:41 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5C4D91004145; Wed, 25 Nov 2020 12:31:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 581411134CC8 for ; Wed, 25 Nov 2020 12:31:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDFE2800BFF for ; Wed, 25 Nov 2020 12:31:37 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-34-J2fYUESWMCm8TdxKhhQmwA-1; Wed, 25 Nov 2020 07:31:35 -0500 X-MC-Unique: J2fYUESWMCm8TdxKhhQmwA-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6A34EAF0E; Wed, 25 Nov 2020 12:31:33 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 3DD711E130F; Wed, 25 Nov 2020 13:31:33 +0100 (CET) Date: Wed, 25 Nov 2020 13:31:33 +0100 From: Jan Kara To: Christoph Hellwig Message-ID: <20201125123133.GI16944@quack2.suse.cz> References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-6-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20201124132751.3747337-6-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Jan Kara , linux-fsdevel@vger.kernel.org, Mike Snitzer , Konrad Rzeszutek Wilk , Greg Kroah-Hartman , Jan Kara , Josef Bacik , Coly Li , linux-block@vger.kernel.org, Richard Weinberger , dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , Tejun Heo , xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mm@kvack.org Subject: Re: [dm-devel] [PATCH 05/45] mtip32xx: remove the call to fsync_bdev on removal X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue 24-11-20 14:27:11, Christoph Hellwig wrote: > del_gendisk already calls fsync_bdev for every partition, no need > to do this twice. > > Signed-off-by: Christoph Hellwig Makes sense to me. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/block/mtip32xx/mtip32xx.c | 15 --------------- > drivers/block/mtip32xx/mtip32xx.h | 2 -- > 2 files changed, 17 deletions(-) > > diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c > index 153e2cdecb4d40..53ac59d19ae530 100644 > --- a/drivers/block/mtip32xx/mtip32xx.c > +++ b/drivers/block/mtip32xx/mtip32xx.c > @@ -3687,7 +3687,6 @@ static int mtip_block_initialize(struct driver_data *dd) > /* Enable the block device and add it to /dev */ > device_add_disk(&dd->pdev->dev, dd->disk, NULL); > > - dd->bdev = bdget_disk(dd->disk, 0); > /* > * Now that the disk is active, initialize any sysfs attributes > * managed by the protocol layer. > @@ -3721,9 +3720,6 @@ static int mtip_block_initialize(struct driver_data *dd) > return rv; > > kthread_run_error: > - bdput(dd->bdev); > - dd->bdev = NULL; > - > /* Delete our gendisk. This also removes the device from /dev */ > del_gendisk(dd->disk); > > @@ -3804,14 +3800,6 @@ static int mtip_block_remove(struct driver_data *dd) > blk_mq_tagset_busy_iter(&dd->tags, mtip_no_dev_cleanup, dd); > blk_mq_unquiesce_queue(dd->queue); > > - /* > - * Delete our gendisk structure. This also removes the device > - * from /dev > - */ > - if (dd->bdev) { > - bdput(dd->bdev); > - dd->bdev = NULL; > - } > if (dd->disk) { > if (test_bit(MTIP_DDF_INIT_DONE_BIT, &dd->dd_flag)) > del_gendisk(dd->disk); > @@ -4206,9 +4194,6 @@ static void mtip_pci_remove(struct pci_dev *pdev) > } while (atomic_read(&dd->irq_workers_active) != 0 && > time_before(jiffies, to)); > > - if (!dd->sr) > - fsync_bdev(dd->bdev); > - > if (atomic_read(&dd->irq_workers_active) != 0) { > dev_warn(&dd->pdev->dev, > "Completion workers still active!\n"); > diff --git a/drivers/block/mtip32xx/mtip32xx.h b/drivers/block/mtip32xx/mtip32xx.h > index e22a7f0523bf30..88f4206310e4c8 100644 > --- a/drivers/block/mtip32xx/mtip32xx.h > +++ b/drivers/block/mtip32xx/mtip32xx.h > @@ -463,8 +463,6 @@ struct driver_data { > > int isr_binding; > > - struct block_device *bdev; > - > struct list_head online_list; /* linkage for online list */ > > struct list_head remove_list; /* linkage for removing list */ > -- > 2.29.2 > -- Jan Kara SUSE Labs, CR -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel