From: Lukas Straub <lukasstraub2@web.de>
To: dm-devel <dm-devel@redhat.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH] dm-integrity: Fix flush with external metadata device
Date: Tue, 29 Dec 2020 10:47:27 +0100 [thread overview]
Message-ID: <20201229104727.3b828165@gecko.fritz.box> (raw)
In-Reply-To: <20201220140222.2f341344@gecko.fritz.box>
[-- Attachment #1.1: Type: text/plain, Size: 1659 bytes --]
On Sun, 20 Dec 2020 14:02:22 +0100
Lukas Straub <lukasstraub2@web.de> wrote:
> With an external metadata device, flush requests aren't passed down
> to the data device.
>
> Fix this by issuing flush in the right places: In integrity_commit
> when not in journal mode, in do_journal_write after writing the
> contents of the journal to the disk and in dm_integrity_postsuspend.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> ---
> drivers/md/dm-integrity.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
> index 5a7a1b90e671..a26ed65869f6 100644
> --- a/drivers/md/dm-integrity.c
> +++ b/drivers/md/dm-integrity.c
> @@ -2196,6 +2196,8 @@ static void integrity_commit(struct work_struct *w)
> if (unlikely(ic->mode != 'J')) {
> spin_unlock_irq(&ic->endio_wait.lock);
> dm_integrity_flush_buffers(ic);
> + if (ic->meta_dev)
> + blkdev_issue_flush(ic->dev->bdev, GFP_NOIO);
> goto release_flush_bios;
> }
>
> @@ -2410,6 +2412,9 @@ static void do_journal_write(struct dm_integrity_c *ic, unsigned write_start,
> wait_for_completion_io(&comp.comp);
>
> dm_integrity_flush_buffers(ic);
> + if (ic->meta_dev)
> + blkdev_issue_flush(ic->dev->bdev, GFP_NOIO);
> +
> }
>
> static void integrity_writer(struct work_struct *w)
> @@ -2949,6 +2954,9 @@ static void dm_integrity_postsuspend(struct dm_target *ti)
> #endif
> }
>
> + if (ic->meta_dev)
> + blkdev_issue_flush(ic->dev->bdev, GFP_NOIO);
> +
> BUG_ON(!RB_EMPTY_ROOT(&ic->in_progress));
>
> ic->journal_uptodate = true;
Ping...
--
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 93 bytes --]
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-01-04 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 13:02 [dm-devel] [PATCH] dm-integrity: Fix flush with external metadata device Lukas Straub
2020-12-29 9:47 ` Lukas Straub [this message]
2021-01-04 20:30 ` [dm-devel] " Mike Snitzer
2021-01-08 16:12 ` Mikulas Patocka
2021-01-08 16:15 ` [dm-devel] [PATCH] " Mikulas Patocka
2021-01-10 10:04 ` Lukas Straub
2021-01-08 18:38 ` [dm-devel] " Mike Snitzer
2021-01-08 19:00 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229104727.3b828165@gecko.fritz.box \
--to=lukasstraub2@web.de \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).