From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Mike Snitzer <snitzer@redhat.com>,
Oleksii Kurochko <olkuroch@cisco.com>,
Dongsheng Yang <dongsheng.yang@easystack.cn>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-nvme@lists.infradead.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Keith Busch <kbusch@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org
Subject: [dm-devel] [PATCH 6/6] nvme: allow revalidate to set a namespace read-only
Date: Sat, 9 Jan 2021 11:42:54 +0100 [thread overview]
Message-ID: <20210109104254.1077093-7-hch@lst.de> (raw)
In-Reply-To: <20210109104254.1077093-1-hch@lst.de>
Unconditionally call set_disk_ro now that it only updates the hardware
state. This allows to properly set up the Linux devices read-only when
the controller turns a previously writable namespace read-only.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
drivers/nvme/host/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index ce1b6151944131..3a0557ccc9fc5d 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2114,9 +2114,8 @@ static void nvme_update_disk_info(struct gendisk *disk,
nvme_config_discard(disk, ns);
nvme_config_write_zeroes(disk, ns);
- if ((id->nsattr & NVME_NS_ATTR_RO) ||
- test_bit(NVME_NS_FORCE_RO, &ns->flags))
- set_disk_ro(disk, true);
+ set_disk_ro(disk, (id->nsattr & NVME_NS_ATTR_RO) ||
+ test_bit(NVME_NS_FORCE_RO, &ns->flags));
}
static inline bool nvme_first_scan(struct gendisk *disk)
--
2.29.2
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-01-09 10:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 10:42 [dm-devel] split hard read-only vs read-only policy v3 (resend) Christoph Hellwig
2021-01-09 10:42 ` [dm-devel] [PATCH 1/6] dm: use bdev_read_only to check if a device is read-only Christoph Hellwig
2021-01-09 10:42 ` [dm-devel] [PATCH 2/6] block: remove the NULL bdev check in bdev_read_only Christoph Hellwig
2021-01-09 20:14 ` Chaitanya Kulkarni
2021-01-10 14:59 ` Hannes Reinecke
2021-01-09 10:42 ` [dm-devel] [PATCH 3/6] block: add a hard-readonly flag to struct gendisk Christoph Hellwig
2021-01-09 10:42 ` [dm-devel] [PATCH 4/6] block: propagate BLKROSET on the whole device to all partitions Christoph Hellwig
2021-01-10 15:00 ` Hannes Reinecke
2021-01-09 10:42 ` [dm-devel] [PATCH 5/6] rbd: remove the ->set_read_only method Christoph Hellwig
2021-01-09 10:42 ` Christoph Hellwig [this message]
2021-01-09 20:27 ` [dm-devel] [PATCH 6/6] nvme: allow revalidate to set a namespace read-only Chaitanya Kulkarni
2021-01-10 15:01 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2020-12-08 16:28 [dm-devel] split hard read-only vs read-only policy v3 Christoph Hellwig
2020-12-08 16:28 ` [dm-devel] [PATCH 6/6] nvme: allow revalidate to set a namespace read-only Christoph Hellwig
2020-12-08 16:49 ` Hannes Reinecke
2020-12-09 2:54 ` Ming Lei
2020-12-07 13:19 [dm-devel] split hard read-only vs read-only policy v2 Christoph Hellwig
2020-12-07 13:19 ` [dm-devel] [PATCH 6/6] nvme: allow revalidate to set a namespace read-only Christoph Hellwig
2020-12-07 18:13 ` Keith Busch
2020-12-08 5:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109104254.1077093-7-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=dongsheng.yang@easystack.cn \
--cc=idryomov@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=olkuroch@cisco.com \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).