From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH 0/3] Multipath io_err_stat fixes
Date: Wed, 13 Jan 2021 11:09:41 -0600 [thread overview]
Message-ID: <20210113170941.GY3103@octiron.msp.redhat.com> (raw)
In-Reply-To: <d4899abd850929066473f4165940d431f20fa6e1.camel@suse.com>
On Wed, Jan 13, 2021 at 11:45:55AM +0000, Martin Wilck wrote:
> On Tue, 2021-01-12 at 17:52 -0600, Benjamin Marzinski wrote:
> > I found an ABBA deadlock in the io_err_stat marginal path code, and
> > in
> > the process of fixing it, noticed a potential crash on shutdown. This
> > patchset addresses both of the issues.
> >
> > Benjamin Marzinski (3):
> > libmultipath: make find_err_path_by_dev() static
> > multipathd: avoid io_err_stat crash during shutdown
> > multipathd: avoid io_err_stat ABBA deadlock
> >
> > libmultipath/io_err_stat.c | 159 +++++++++++++++++------------------
> > --
> > 1 file changed, 73 insertions(+), 86 deletions(-)
> >
>
> Thanks, the series looks good, I have only minor nits.
>
> I've made some remarks about the io_err_stat code in the review. While
> you're working at it, would you be willing to fix those issues too?
Sure. I'll send out a v2 patchset that addresses all your issues.
-Ben
>
> Cheers,
> Martin
>
> --
> Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
> SUSE Software Solutions Germany GmbH
> HRB 36809, AG Nürnberg GF: Felix Imendörffer
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2021-01-13 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 23:52 [dm-devel] [PATCH 0/3] Multipath io_err_stat fixes Benjamin Marzinski
2021-01-12 23:52 ` [dm-devel] [PATCH 1/3] libmultipath: make find_err_path_by_dev() static Benjamin Marzinski
2021-01-12 23:52 ` [dm-devel] [PATCH 2/3] multipathd: avoid io_err_stat crash during shutdown Benjamin Marzinski
2021-01-13 11:45 ` Martin Wilck
2021-01-12 23:52 ` [dm-devel] [PATCH 3/3] multipathd: avoid io_err_stat ABBA deadlock Benjamin Marzinski
2021-01-13 11:45 ` Martin Wilck
2021-01-13 11:45 ` [dm-devel] [PATCH 0/3] Multipath io_err_stat fixes Martin Wilck
2021-01-13 17:09 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113170941.GY3103@octiron.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
--cc=martin.wilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).