Re: [dm-devel] [PATCH v5 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case

From: kernel test robot <lkp@intel.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	nvdimm@lists.linux.dev, linux-mm@kvack.org,
	 linux-fsdevel@vger.kernel.org, dm-devel@redhat.com
Cc: kbuild-all@lists.01.org, darrick.wong@oracle.com,
	david@fromorbit.com, clang-built-linux@googlegroups.com,
	dan.j.williams@intel.com, hch@lst.de
Subject: Re: [dm-devel] [PATCH v5 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case
Date: Mon, 28 Jun 2021 11:23:38 +0800	[thread overview]
Message-ID: <202106281100.TfvJ1yLN-lkp@intel.com> (raw)
In-Reply-To: <20210628000218.387833-6-ruansy.fnst@fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 2964 bytes --]

Hi Shiyang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.13 next-20210625]
[cannot apply to hnaz-linux-mm/master xfs-linux/for-next dm/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shiyang-Ruan/fsdax-introduce-fs-query-to-support-reflink/20210628-080346
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 62fb9874f5da54fdb243003b386128037319b219
config: x86_64-randconfig-a006-20210628 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4c92e31dd0f1bd152eda883af20ff7fbcaa14945)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/dc92f6aa75da7bf5c6f974645a157759691ca36a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shiyang-Ruan/fsdax-introduce-fs-query-to-support-reflink/20210628-080346
        git checkout dc92f6aa75da7bf5c6f974645a157759691ca36a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> mm/memory-failure.c:1325:22: error: implicit declaration of function 'dax_load_pfn' [-Werror,-Wimplicit-function-declaration]
           unsigned long pfn = dax_load_pfn(mapping, index);
                               ^
   1 error generated.

vim +/dax_load_pfn +1325 mm/memory-failure.c

  1320	
  1321	int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, int flags)
  1322	{
  1323		LIST_HEAD(to_kill);
  1324		/* load the pfn of the dax mapping file */
> 1325		unsigned long pfn = dax_load_pfn(mapping, index);
  1326	
  1327		/*
  1328		 * Unlike System-RAM there is no possibility to swap in a
  1329		 * different physical page at a given virtual address, so all
  1330		 * userspace consumption of ZONE_DEVICE memory necessitates
  1331		 * SIGBUS (i.e. MF_MUST_KILL)
  1332		 */
  1333		flags |= MF_ACTION_REQUIRED | MF_MUST_KILL;
  1334		collect_procs_file(pfn_to_page(pfn), mapping, index, &to_kill,
  1335				   flags & MF_ACTION_REQUIRED);
  1336	
  1337		unmap_and_kill(&to_kill, pfn, mapping, index, flags);
  1338		return 0;
  1339	}
  1340	EXPORT_SYMBOL_GPL(mf_dax_kill_procs);
  1341	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45536 bytes --]

[-- Attachment #3: Type: text/plain, Size: 97 bytes --]

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel