From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F923C4338F for ; Mon, 9 Aug 2021 06:53:34 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBD0F60234 for ; Mon, 9 Aug 2021 06:53:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CBD0F60234 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-224-ANulQfzoMmqJu_e0lX_7vA-1; Mon, 09 Aug 2021 02:53:31 -0400 X-MC-Unique: ANulQfzoMmqJu_e0lX_7vA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E71C3180FCBC; Mon, 9 Aug 2021 06:53:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C78225D9D3; Mon, 9 Aug 2021 06:53:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9CCD9180BAB3; Mon, 9 Aug 2021 06:53:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 174Ef0ZS008356 for ; Wed, 4 Aug 2021 10:41:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id 47A4DF8858; Wed, 4 Aug 2021 14:41:00 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42108F8087 for ; Wed, 4 Aug 2021 14:40:57 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B9E578D138C for ; Wed, 4 Aug 2021 14:40:57 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-9xYgexR9P8WX7s0o-4M6lg-1; Wed, 04 Aug 2021 10:40:56 -0400 X-MC-Unique: 9xYgexR9P8WX7s0o-4M6lg-1 Received: by mail.kernel.org (Postfix) with ESMTPSA id AA66960F58; Wed, 4 Aug 2021 14:33:14 +0000 (UTC) Date: Wed, 4 Aug 2021 07:33:12 -0700 From: Keith Busch To: Christoph Hellwig Message-ID: <20210804143312.GA2296276@dhcp-10-100-145-180.wdc.com> References: <20210804095634.460779-1-hch@lst.de> <20210804095634.460779-16-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20210804095634.460779-16-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Mon, 09 Aug 2021 02:53:04 -0400 Cc: Jan Hoeppner , Mike Snitzer , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, Song Liu , dm-devel@redhat.com, Anton Ivanov , linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Ilya Dryomov , linux-um@lists.infradead.org, Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, Stefan Haberland , Stefan Hajnoczi , Paolo Bonzini , ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , Geoff Levand , Phillip Lougher Subject: Re: [dm-devel] [PATCH 15/15] nvme: use bvec_virt X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Aug 04, 2021 at 11:56:34AM +0200, Christoph Hellwig wrote: > Use bvec_virt instead of open coding it. > > Signed-off-by: Christoph Hellwig > --- > drivers/nvme/host/core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index dfd9dec0c1f6..02ce94b2906b 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -968,12 +968,11 @@ void nvme_cleanup_cmd(struct request *req) > { > if (req->rq_flags & RQF_SPECIAL_PAYLOAD) { > struct nvme_ctrl *ctrl = nvme_req(req)->ctrl; > - struct page *page = req->special_vec.bv_page; > > - if (page == ctrl->discard_page) > + if (req->special_vec.bv_page == ctrl->discard_page) > clear_bit_unlock(0, &ctrl->discard_page_busy); > else > - kfree(page_address(page) + req->special_vec.bv_offset); > + kfree(bvec_virt(&req->special_vec)); > } > } > EXPORT_SYMBOL_GPL(nvme_cleanup_cmd); Looks good. Reviewed-by: Keith Busch -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel