From: mwilck@suse.com
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [dm-devel] [PATCH 0/3] multipath-tools: final touces before next PR
Date: Tue, 7 Sep 2021 08:56:33 +0200 [thread overview]
Message-ID: <20210907065636.22937-1-mwilck@suse.com> (raw)
From: Martin Wilck <mwilck@suse.com>
Hello Christophe, hello Ben,
here are a few final small fixes for the next multipath-tools PR:
https://github.com/opensvc/multipath-tools/pull/13
(Christophe, please give Ben a few days for review before merging).
Notes:
- The patch for libmultipath.version differs from the one I posted
previously (https://listman.redhat.com/archives/dm-devel/2021-September/msg00011.html).
In the previous one I hadn't sticked to the guide line I had
set up myself (bumping the version of every symbol in the ABI
for incompatible changes). The previous patch (bumping only the
version of the symbols that had actually changed) has some advantages,
in particular being able to track which symbols actually differ between
versions. We may want to discuss changing the policy towards
this procedure in the future, but we can't do it silently like I did
in the first version of this patch.
- I wrote previously that "libmultipath: drop unnecessary parameter
from remove_map()" broke the directio test, but that was a braino.
It broke the dmevents tests. The fix is in this series.
Regards,
Martin
Martin Wilck (3):
libmultipath.version: adapt to changes in remove_map
multipath-tools tests: fix dmevents test
Update .gitignore
.gitignore | 4 ++++
libmultipath/libmultipath.version | 17 +++++++----------
tests/dmevents.c | 4 +---
3 files changed, 12 insertions(+), 13 deletions(-)
--
2.33.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next reply other threads:[~2021-09-07 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 6:56 mwilck [this message]
2021-09-07 6:56 ` [dm-devel] [PATCH v2 1/3] libmultipath.version: adapt to changes in remove_map mwilck
2021-09-07 6:56 ` [dm-devel] [PATCH 2/3] multipath-tools tests: fix dmevents test mwilck
2021-09-07 6:56 ` [dm-devel] [PATCH 3/3] Update .gitignore mwilck
2021-09-07 21:51 ` [dm-devel] [PATCH 0/3] multipath-tools: final touces before next PR Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907065636.22937-1-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).