From: Steve Grubb <sgrubb@redhat.com>
To: "Weiß, Michael" <michael.weiss@aisec.fraunhofer.de>,
"Richard Guy Briggs" <rgb@redhat.com>
Cc: "paul@paul-moore.com" <paul@paul-moore.com>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"eparis@redhat.com" <eparis@redhat.com>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"song@kernel.org" <song@kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-audit@redhat.com" <linux-audit@redhat.com>,
"casey@schaufler-ca.com" <casey@schaufler-ca.com>,
"agk@redhat.com" <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH v4 0/3] dm: audit event logging
Date: Wed, 08 Sep 2021 11:39:02 -0400 [thread overview]
Message-ID: <4344604.LvFx2qVVIh@x2> (raw)
In-Reply-To: <20210908131616.GK490529@madcap2.tricolour.ca>
On Wednesday, September 8, 2021 9:16:16 AM EDT Richard Guy Briggs wrote:
> Another minor oddity is the double "=" for the subj
>
> > > field, which doesn't appear to be a bug in your code, but still
> > > puzzling.
> >
> > In the test setup, I had Apparmor enabled and set as default security
> > module. This behavior occurs in any audit_log message.
> > Seems that this is coming from the label handling there. Having a quick
> > look at the code there is that they use '=' in the label to provide a
> > root view as part of their policy virtualization. The corresponding
> > commit is sitting there since 2017:
> > "26b7899510ae243e392960704ebdba52d05fbb13"
>
> Interesting... Thanks for tracking down that cause. I don't know how
> much pain that will cause the userspace parsing tools. I've added Steve
> Grubb to the Cc: to get his input, but this should not derail this patch
> set.
It likely breaks any parser. I would even say that it's a malformed event
that should be corrected. There's been a published a specification for audit
events for at least 5 years. Latest copy is here:
https://github.com/linux-audit/audit-documentation/wiki/SPEC-Writing-Good-Events
-Steve
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-09-13 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 9:59 [dm-devel] [PATCH v4 0/3] dm: audit event logging Michael Weiß
2021-09-04 9:59 ` [dm-devel] [PATCH v4 1/3] dm: introduce audit event module for device mapper Michael Weiß
2021-09-04 9:59 ` [dm-devel] [PATCH v4 2/3] dm integrity: log audit events for dm-integrity target Michael Weiß
2021-09-04 9:59 ` [dm-devel] [PATCH v4 3/3] dm crypt: log aead integrity violations to audit subsystem Michael Weiß
2021-09-08 0:59 ` [dm-devel] [PATCH v4 0/3] dm: audit event logging Richard Guy Briggs
2021-09-08 8:26 ` Weiß, Michael
2021-09-08 13:16 ` Richard Guy Briggs
2021-09-08 15:39 ` Steve Grubb [this message]
2021-09-12 9:38 ` Weiß, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4344604.LvFx2qVVIh@x2 \
--to=sgrubb@redhat.com \
--cc=agk@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=dm-devel@redhat.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=michael.weiss@aisec.fraunhofer.de \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=snitzer@redhat.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).