From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62C78C4338F for ; Mon, 9 Aug 2021 06:53:39 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBE3060EE4 for ; Mon, 9 Aug 2021 06:53:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EBE3060EE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-pblvY1edNJCos0zomx-zWg-1; Mon, 09 Aug 2021 02:53:36 -0400 X-MC-Unique: pblvY1edNJCos0zomx-zWg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 817F3107465F; Mon, 9 Aug 2021 06:53:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6205960CD1; Mon, 9 Aug 2021 06:53:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3A161180BABF; Mon, 9 Aug 2021 06:53:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 175CB42g032188 for ; Thu, 5 Aug 2021 08:11:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 409C121D0DAD; Thu, 5 Aug 2021 12:11:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BCBE21D0DAC for ; Thu, 5 Aug 2021 12:11:00 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 732B180B725 for ; Thu, 5 Aug 2021 12:11:00 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-QheF99C4P9igJRRBHIAxsg-1; Thu, 05 Aug 2021 08:10:56 -0400 X-MC-Unique: QheF99C4P9igJRRBHIAxsg-1 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3A71D61132; Thu, 5 Aug 2021 12:01:14 +0000 (UTC) Message-ID: <440e1815a8b6f1605b6bce51af6eceadf8e742f7.camel@kernel.org> From: Jeff Layton To: Christoph Hellwig , Jens Axboe Date: Thu, 05 Aug 2021 08:01:13 -0400 In-Reply-To: <20210804095634.460779-8-hch@lst.de> References: <20210804095634.460779-1-hch@lst.de> <20210804095634.460779-8-hch@lst.de> User-Agent: Evolution 3.40.3 (3.40.3-1.fc34) MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Mon, 09 Aug 2021 02:53:04 -0400 Cc: Jan Hoeppner , Mike Snitzer , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, Song Liu , dm-devel@redhat.com, Anton Ivanov , linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Dryomov , Stefan, linux-um@lists.infradead.org, Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, Stefan Haberland , Hajnoczi , Paolo Bonzini , ceph-devel@vger.kernel.org, linux-block@vger.kernel.org, "Martin K. Petersen" , Ilya, Geoff Levand , Phillip Lougher Subject: Re: [dm-devel] [PATCH 07/15] rbd: use bvec_virt X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, 2021-08-04 at 11:56 +0200, Christoph Hellwig wrote: > Use bvec_virt instead of open coding it. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rbd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index 6d596c2c2cd6..e65c9d706f6f 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -2986,8 +2986,7 @@ static bool is_zero_bvecs(struct bio_vec *bvecs, u32 bytes) > }; > > ceph_bvec_iter_advance_step(&it, bytes, ({ > - if (memchr_inv(page_address(bv.bv_page) + bv.bv_offset, 0, > - bv.bv_len)) > + if (memchr_inv(bvec_virt(&bv), 0, bv.bv_len)) > return false; > })); > return true; LGTM Reviewed-by: Jeff Layton -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel