From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH 3/3] libmultipath: add ignore_udev_uid option Date: Wed, 16 Sep 2020 14:46:18 +0000 Message-ID: <6442fa8e24eaa44a5487d16de95a712ed9d76125.camel@suse.com> References: <1600206312-6497-1-git-send-email-bmarzins@redhat.com> <1600206312-6497-4-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1600206312-6497-4-git-send-email-bmarzins@redhat.com> Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Content-Language: en-US To: "bmarzins@redhat.com" , "christophe.varoqui@opensvc.com" Cc: "dm-devel@redhat.com" List-Id: dm-devel.ids Hi Ben, On Tue, 2020-09-15 at 16:45 -0500, Benjamin Marzinski wrote: > Setting this option to yes will force multipath to get the uid by > using > the fallback sysfs methods, instead of getting it from udev. This > will > cause devices that can't get their uid from the standard locations to > not get a uid. It will also disable uevent merging. >=20 > It will not stop uevents from being resent for device that failed to > get a WWID, although I'm on the fence about the benefit of this. >=20 > Signed-off-by: Benjamin Marzinski Can you explain how this differs from setting uid_attribute to the empty string (and leaving uid_attrs at the default, empty)? The patch is alright, but the configuration of WWID determination is already sooo complicated... I'm not too happy about adding yet another option which complicates matters further. IMO we should rather attempt to make this easier for users (meaning less options, less combinations thereof, and less "x supersedes y but only if z is not set" kind of logic). This is not a nack, I just want to understand. Regards Martin -- Dr. Martin Wilck , Tel. +49 (0)911 74053 2107 SUSE Software Solutions Germany GmbH HRB 36809, AG N=FCrnberg GF: Felix Imend=F6rffer