From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB78CC433DF for ; Fri, 16 Oct 2020 19:51:33 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3EDF2083B for ; Fri, 16 Oct 2020 19:51:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3EDF2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-C8R6zscEP3S6hGcqjkCn6w-1; Fri, 16 Oct 2020 15:51:29 -0400 X-MC-Unique: C8R6zscEP3S6hGcqjkCn6w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8B208100746C; Fri, 16 Oct 2020 19:51:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F37927CC8; Fri, 16 Oct 2020 19:51:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F2D76180B658; Fri, 16 Oct 2020 19:51:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 09GJpGCW026766 for ; Fri, 16 Oct 2020 15:51:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 27232117C0B; Fri, 16 Oct 2020 19:51:16 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20D74170422 for ; Fri, 16 Oct 2020 19:51:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 04CE285828F for ; Fri, 16 Oct 2020 19:51:10 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-524-xI8voJjiMPS16JlsvTejbA-1; Fri, 16 Oct 2020 15:51:07 -0400 X-MC-Unique: xI8voJjiMPS16JlsvTejbA-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 18E11AD0B; Fri, 16 Oct 2020 19:51:06 +0000 (UTC) Message-ID: <757aa2249e036cf2c659bedd6c9fe748af3c0894.camel@suse.com> From: Martin Wilck To: lixiaokeng , Christophe Varoqui , Benjamin Marzinski , dm-devel mailing list Date: Fri, 16 Oct 2020 21:51:04 +0200 In-Reply-To: <6169bcfa-343d-adc8-a458-5e5c46aed737@huawei.com> References: <6169bcfa-343d-adc8-a458-5e5c46aed737@huawei.com> User-Agent: Evolution 3.36.5 MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Cc: linfeilong , "liuzhiqiang \(I\)" Subject: Re: [dm-devel] [PATCH] libmultipath: fix memory leaks in coalesce_paths X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, 2020-10-16 at 14:23 +0800, lixiaokeng wrote: > When multipath -F are executed firstly and multipath -v2 or > -d are executed later, asan will warn memory leaks. The > reason is that the mpp allocated in coalesce_paths isn't > freed. Here we add newmp in configure(multipath) to store > mpp and free it. > > Signed-off-by: Lixiaokeng > Signed-off-by: Zhiqiang Liu > Signed-off-by: Linfeilong Besides what Ben noted already, I think you shouldn't force callers to pass a non-NULL "newmp". The tricky part is to make sure that paths aren't handled repeatedly in the CMD_DRY_RUN case. Currently pp->mpp != NULL is the condition used by coalesce_paths() to check if a path has already been dealt with; if you simply call remove_map(), that won't work any more. I suppose you realized that, and that's why you introduced the non-NULL newmp in multipath (you should have mentioned that in the changelog message). I suggest to have callers pass a "vector *pnewmp" instead of "vector newmp", always allocate newmp in coalesce_paths(), and upon return, either free newmp, or assign it to the pointer passed by the caller: if (pnewmp) *pnewmp = newmp; else free_multipathvec(newmp, KEEP_PATHS); Regards, Martin -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel