From: Milan Broz <gmazyland@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: [dm-devel] use regular gendisk registration in device mapper
Date: Wed, 28 Jul 2021 10:37:41 +0200 [thread overview]
Message-ID: <9e668239-78cc-55ad-8998-b7e39f573c34@gmail.com> (raw)
In-Reply-To: <20210728070655.GA5086@lst.de>
On 28/07/2021 09:06, Christoph Hellwig wrote:
> On Tue, Jul 27, 2021 at 10:38:16PM +0200, Milan Broz wrote:
>> BTW it would be also nice to run cryptsetup testsuite as root - we do a lot
>> of DM operations there (and we depend on sysfs on some places).
>
> It already doesn't seem very happy in current mainline for me:
>
> =======================
> 13 of 17 tests failed
> (12 tests were not run)
> =======================
>
> but this series doesn't seem to change anything.
>
> A lot of the not run tests seem to be due to broken assumptions
> that some code must be modular. E.g. my kernel has scsi_debug built
> in, but it complains like this:
>
> modprobe: ERROR: ../libkmod/libkmod.c:586 kmod_search_moddep() could not open moddep file '/lib/module'
> modprobe: FATAL: Module scsi_debug not found in directory /lib/modules/5.14.0-rc3+
Hi,
there should not be many assumptions, but yes, we depend on modular scsi_debug in some tests because we simulate
very specific hw attributes. So you have one emulated device compiled-in?
Or there is another way how to configure scsi_debug if compiled-in? (we use module parameters, I think it is
the same was how util-linux testsute works with scsi_debug).
Anyway, this is a bug, tests should be skipped (the same way if scsi_debug is not available).
I forgot to say - there is a list of packages that should be installed for make check mentioned
in README.md - I guess this was the reason some other tests were skipped.
(BTW could you send me output of the failed test run? I run it over Linus' tree and ti works so it is perhaps another
assumption that should be fixed.)
Thanks,
Milan
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-07-28 8:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 5:54 [dm-devel] use regular gendisk registration in device mapper Christoph Hellwig
2021-07-25 5:54 ` [dm-devel] [PATCH 1/8] block: make the block holder code optional Christoph Hellwig
2021-07-29 16:25 ` Mike Snitzer
2021-07-25 5:54 ` [dm-devel] [PATCH 2/8] block: remove the extra kobject reference in bd_link_disk_holder Christoph Hellwig
2021-07-29 16:27 ` Mike Snitzer
2021-07-25 5:54 ` [dm-devel] [PATCH 3/8] block: look up holders by bdev Christoph Hellwig
2021-07-25 5:54 ` [dm-devel] [PATCH 4/8] block: support delayed holder registration Christoph Hellwig
2021-07-27 16:06 ` Mike Snitzer
2021-07-28 6:54 ` Christoph Hellwig
2021-07-29 16:32 ` Mike Snitzer
2021-07-25 5:54 ` [dm-devel] [PATCH 5/8] dm: cleanup cleanup_mapped_device Christoph Hellwig
2021-07-29 16:33 ` Mike Snitzer
2021-07-25 5:54 ` [dm-devel] [PATCH 6/8] dm: move setting md->type into dm_setup_md_queue Christoph Hellwig
2021-07-29 16:34 ` Mike Snitzer
2021-07-25 5:54 ` [dm-devel] [PATCH 7/8] dm: delay registering the gendisk Christoph Hellwig
2021-07-29 16:36 ` Mike Snitzer
2021-07-25 5:54 ` [dm-devel] [PATCH 8/8] block: remove support for delayed queue registrations Christoph Hellwig
2021-07-29 16:37 ` Mike Snitzer
2021-07-27 15:58 ` [dm-devel] use regular gendisk registration in device mapper Mike Snitzer
2021-07-27 16:02 ` Christoph Hellwig
2021-07-27 16:18 ` Mike Snitzer
2021-07-27 20:38 ` Milan Broz
2021-07-28 7:06 ` Christoph Hellwig
2021-07-28 8:37 ` Milan Broz [this message]
2021-07-28 11:24 ` Christoph Hellwig
2021-07-29 15:01 ` Milan Broz
2021-07-28 16:17 ` Mike Snitzer
2021-07-29 7:50 ` Milan Broz
2021-07-27 22:52 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e668239-78cc-55ad-8998-b7e39f573c34@gmail.com \
--to=gmazyland@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).