From: Ming Hung Tsai <mtsai@redhat.com>
To: dm-devel@redhat.com, ntsironis@arrikto.com
Cc: Edward Thornber <ejt@redhat.com>,
agk@redhat.com, Mike Snitzer <snitzer@redhat.com>
Subject: Re: [dm-devel] [PATCH 0/4] dm era: Various minor fixes
Date: Thu, 11 Feb 2021 01:56:24 +0800 [thread overview]
Message-ID: <CALjSBEuWgLHiPwkrMCpUWWV3VOOO98ZydCrzs1_qvCjSnyO5GQ@mail.gmail.com> (raw)
In-Reply-To: <20210122152556.24822-1-ntsironis@arrikto.com>
On Fri, Jan 22, 2021 at 11:30 PM Nikos Tsironis <ntsironis@arrikto.com> wrote:
>
> While working on fixing the bugs that cause lost writes, for which I
> have sent separate emails, I bumped into several other minor issues that
> I fix in this patch set.
>
> In particular, this series of commits introduces the following fixes:
>
> 1. Add explicit check that the data block size hasn't changed
> 2. Fix bitset memory leaks. The in-core bitmaps were never freed.
> 3. Fix the writeset tree equality test function to use the right value
> size.
> 4. Remove unreachable resize operation in pre-resume function.
>
> More information about the fixes can be found in their commit messages.
>
> Nikos Tsironis (4):
> dm era: Verify the data block size hasn't changed
> dm era: Fix bitset memory leaks
> dm era: Use correct value size in equality function of writeset tree
> dm era: Remove unreachable resize operation in pre-resume function
>
> drivers/md/dm-era-target.c | 27 ++++++++++++++++-----------
> 1 file changed, 16 insertions(+), 11 deletions(-)
For the series, except 4/4 where I haven't tried other solutions.
Reviewed-by: Ming-Hung Tsai <mtsai@redhat.com>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-02-10 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 15:25 [dm-devel] [PATCH 0/4] dm era: Various minor fixes Nikos Tsironis
2021-01-22 15:25 ` [dm-devel] [PATCH 1/4] dm era: Verify the data block size hasn't changed Nikos Tsironis
2021-01-22 15:25 ` [dm-devel] [PATCH 2/4] dm era: Fix bitset memory leaks Nikos Tsironis
2021-01-22 15:25 ` [dm-devel] [PATCH 3/4] dm era: Use correct value size in equality function of writeset tree Nikos Tsironis
2021-01-22 15:25 ` [dm-devel] [PATCH 4/4] dm era: Remove unreachable resize operation in pre-resume function Nikos Tsironis
2021-02-10 18:12 ` Mike Snitzer
2021-02-10 18:48 ` Mike Snitzer
2021-02-11 14:19 ` Nikos Tsironis
2021-02-10 17:56 ` Ming Hung Tsai [this message]
2021-02-10 18:34 ` [dm-devel] [PATCH 0/4] dm era: Various minor fixes Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALjSBEuWgLHiPwkrMCpUWWV3VOOO98ZydCrzs1_qvCjSnyO5GQ@mail.gmail.com \
--to=mtsai@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=ntsironis@arrikto.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).