From: Ilya Dryomov <idryomov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless@vger.kernel.org, linux-fbdev@vger.kernel.org,
oss-drivers@netronome.com, nouveau@lists.freedesktop.org,
alsa-devel <alsa-devel@alsa-project.org>,
dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org,
linux-ide@vger.kernel.org, dm-devel@redhat.com,
linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org,
sparclinux@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org,
linux-scsi@vger.kernel.org, dccp@vger.kernel.org,
linux-rdma@vger.kernel.org,
linux-atm-general@lists.sourceforge.net,
linux-afs@lists.infradead.org, coreteam@netfilter.org,
intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org,
linux-input@vger.kernel.org, linux-mmc@vger.kernel.org,
Kees Cook <kees.cook@canonical.com>,
linux-media@vger.kernel.org, linux-pm@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-sctp@vger.kerne
Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;
Date: Thu, 10 Sep 2020 11:24:26 +0200 [thread overview]
Message-ID: <CAOi1vP-v77pj3G5Ez94CDYVs2jSO828c4uV_wzNi6sRKp=Yvyg@mail.gmail.com> (raw)
In-Reply-To: <e6387578c75736d61b2fe70d9783d91329a97eb4.camel@perches.com>
On Wed, Sep 9, 2020 at 10:10 PM Joe Perches <joe@perches.com> wrote:
>
> fallthrough to a separate case/default label break; isn't very readable.
>
> Convert pseudo-keyword fallthrough; statements to a simple break; when
> the next label is case or default and the only statement in the next
> label block is break;
>
> Found using:
>
> $ grep-2.5.4 -rP --include=*.[ch] -n "fallthrough;(\s*(case\s+\w+|default)\s*:\s*){1,7}break;" *
>
> Miscellanea:
>
> o Move or coalesce a couple label blocks above a default: block.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> Compiled allyesconfig x86-64 only.
> A few files for other arches were not compiled.
>
> arch/arm/mach-mmp/pm-pxa910.c | 2 +-
> arch/arm64/kvm/handle_exit.c | 2 +-
> arch/mips/kernel/cpu-probe.c | 2 +-
> arch/mips/math-emu/cp1emu.c | 2 +-
> arch/s390/pci/pci.c | 2 +-
> crypto/tcrypt.c | 4 ++--
> drivers/ata/sata_mv.c | 2 +-
> drivers/atm/lanai.c | 2 +-
> drivers/gpu/drm/i915/display/intel_sprite.c | 2 +-
> drivers/gpu/drm/nouveau/nvkm/engine/disp/hdmi.c | 2 +-
> drivers/hid/wacom_wac.c | 2 +-
> drivers/i2c/busses/i2c-i801.c | 2 +-
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 14 +++++++-------
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 6 +++---
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
> drivers/irqchip/irq-vic.c | 4 ++--
> drivers/md/dm.c | 2 +-
> drivers/media/dvb-frontends/drxd_hard.c | 2 +-
> drivers/media/i2c/ov5640.c | 2 +-
> drivers/media/i2c/ov6650.c | 5 ++---
> drivers/media/i2c/smiapp/smiapp-core.c | 2 +-
> drivers/media/i2c/tvp5150.c | 2 +-
> drivers/media/pci/ddbridge/ddbridge-core.c | 2 +-
> drivers/media/usb/cpia2/cpia2_core.c | 2 +-
> drivers/mfd/iqs62x.c | 3 +--
> drivers/mmc/host/atmel-mci.c | 2 +-
> drivers/mtd/nand/raw/nandsim.c | 2 +-
> drivers/net/ethernet/intel/e1000e/phy.c | 2 +-
> drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 2 +-
> drivers/net/ethernet/intel/i40e/i40e_adminq.c | 2 +-
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
> drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +-
> drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
> drivers/net/ethernet/intel/ixgbevf/vf.c | 2 +-
> drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c | 2 +-
> drivers/net/ethernet/qlogic/qed/qed_mcp.c | 2 +-
> drivers/net/ethernet/sfc/falcon/farch.c | 2 +-
> drivers/net/ethernet/sfc/farch.c | 2 +-
> drivers/net/phy/adin.c | 3 +--
> drivers/net/usb/pegasus.c | 4 ++--
> drivers/net/usb/usbnet.c | 2 +-
> drivers/net/wireless/ath/ath5k/eeprom.c | 2 +-
> drivers/net/wireless/mediatek/mt7601u/dma.c | 8 ++++----
> drivers/nvme/host/core.c | 12 ++++++------
> drivers/pcmcia/db1xxx_ss.c | 4 ++--
> drivers/power/supply/abx500_chargalg.c | 2 +-
> drivers/power/supply/charger-manager.c | 2 +-
> drivers/rtc/rtc-pcf85063.c | 2 +-
> drivers/s390/scsi/zfcp_fsf.c | 2 +-
> drivers/scsi/aic7xxx/aic79xx_core.c | 4 ++--
> drivers/scsi/aic94xx/aic94xx_tmf.c | 2 +-
> drivers/scsi/lpfc/lpfc_sli.c | 2 +-
> drivers/scsi/smartpqi/smartpqi_init.c | 2 +-
> drivers/scsi/sr.c | 2 +-
> drivers/tty/serial/sunsu.c | 2 +-
> drivers/tty/serial/sunzilog.c | 2 +-
> drivers/tty/vt/vt_ioctl.c | 2 +-
> drivers/usb/dwc3/core.c | 2 +-
> drivers/usb/gadget/legacy/inode.c | 2 +-
> drivers/usb/gadget/udc/pxa25x_udc.c | 4 ++--
> drivers/usb/host/ohci-hcd.c | 2 +-
> drivers/usb/isp1760/isp1760-hcd.c | 2 +-
> drivers/usb/musb/cppi_dma.c | 2 +-
> drivers/usb/phy/phy-fsl-usb.c | 2 +-
> drivers/video/fbdev/stifb.c | 2 +-
> fs/afs/yfsclient.c | 8 ++++----
> fs/ceph/dir.c | 2 +-
For ceph:
Acked-by: Ilya Dryomov <idryomov@gmail.com>
Thanks,
Ilya
next prev parent reply other threads:[~2020-09-10 9:24 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 20:06 [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Joe Perches
2020-09-09 20:38 ` Gustavo A. R. Silva
2020-09-09 20:55 ` Keith Busch
2020-09-17 19:40 ` Jacob Keller
2020-09-10 6:53 ` Wolfram Sang
2020-09-10 8:47 ` Felipe Balbi
2020-09-10 9:18 ` Steffen Maier
2020-09-10 9:24 ` Ilya Dryomov [this message]
2020-09-10 10:16 ` Matthias Brugger
2020-09-10 14:21 ` Robin Murphy
2020-09-11 4:19 ` Joe Perches
2020-09-15 9:06 ` [Intel-gfx] " Jani Nikula
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
[not found] ` <e6387578c75736d61b2fe70d9783d91329a97eb4.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2020-09-09 22:36 ` Jason Gunthorpe
2020-09-09 22:47 ` Joe Perches
2020-09-10 6:28 ` Mauro Carvalho Chehab
2020-09-10 8:24 ` Nicolas.Ferre--- via iommu
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-15 9:19 ` Miquel Raynal
2020-09-17 8:03 ` [oss-drivers] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOi1vP-v77pj3G5Ez94CDYVs2jSO828c4uV_wzNi6sRKp=Yvyg@mail.gmail.com' \
--to=idryomov@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=coreteam@netfilter.org \
--cc=dccp@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joe@perches.com \
--cc=kees.cook@canonical.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-afs@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kerne \
--cc=linux-serial@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=oss-drivers@netronome.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).