Re: [dm-devel] [RFC PATCH] blk-core: remove blk_put_request()

From: Stefan Hajnoczi <stefanha@redhat.com>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: ulf.hansson@linaro.org, snitzer@redhat.com, mst@redhat.com,
	jasowang@redhat.com, virtualization@lists.linux-foundation.org,
	bfields@fieldses.org, linux-ide@vger.kernel.org,
	dm-devel@redhat.com, target-devel@vger.kernel.org,
	alim.akhtar@samsung.com, agk@redhat.com, beanhuo@micron.com,
	stanley.chu@mediatek.com, linux-scsi@vger.kernel.org,
	cang@codeaurora.org, tim@cyberelk.net, dgilbert@interlog.com,
	vbadigan@codeaurora.org, richard.peng@oppo.com,
	jejb@linux.ibm.com, guoqing.jiang@cloud.ionos.com,
	linux-block@vger.kernel.org, avri.altman@wdc.com, bp@alien8.de,
	jaegeuk@kernel.org, Kai.Makisara@kolumbus.fi, axboe@kernel.dk,
	linux-nfs@vger.kernel.org, martin.petersen@oracle.com,
	baolin.wang@linaro.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp,
	chuck.lever@oracle.com, zliua@micron.com, pbonzini@redhat.com,
	davem@davemloft.net, asutoshd@codeaurora.org
Subject: Re: [dm-devel] [RFC PATCH] blk-core: remove blk_put_request()
Date: Wed, 24 Feb 2021 11:53:29 +0000	[thread overview]
Message-ID: <YDY+ObNNiBMMuSEt@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210222211115.30416-1-chaitanya.kulkarni@wdc.com>

[-- Attachment #1.1: Type: text/plain, Size: 2511 bytes --]

On Mon, Feb 22, 2021 at 01:11:15PM -0800, Chaitanya Kulkarni wrote:
> The function blk_put_request() is just a wrapper to
> blk_mq_free_request(), remove the unnecessary wrapper.
> 
> Any feedback is welcome on this RFC.
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
>  block/blk-core.c                   |  6 ------
>  block/blk-merge.c                  |  2 +-
>  block/bsg-lib.c                    |  4 ++--
>  block/bsg.c                        |  4 ++--
>  block/scsi_ioctl.c                 |  6 +++---
>  drivers/block/paride/pd.c          |  2 +-
>  drivers/block/pktcdvd.c            |  2 +-
>  drivers/block/virtio_blk.c         |  2 +-
>  drivers/cdrom/cdrom.c              |  4 ++--
>  drivers/ide/ide-atapi.c            |  2 +-
>  drivers/ide/ide-cd.c               |  4 ++--
>  drivers/ide/ide-cd_ioctl.c         |  2 +-
>  drivers/ide/ide-devsets.c          |  2 +-
>  drivers/ide/ide-disk.c             |  2 +-
>  drivers/ide/ide-ioctls.c           |  4 ++--
>  drivers/ide/ide-park.c             |  2 +-
>  drivers/ide/ide-pm.c               |  4 ++--
>  drivers/ide/ide-tape.c             |  2 +-
>  drivers/ide/ide-taskfile.c         |  2 +-
>  drivers/md/dm-mpath.c              |  2 +-
>  drivers/mmc/core/block.c           | 10 +++++-----
>  drivers/scsi/scsi_error.c          |  2 +-
>  drivers/scsi/scsi_lib.c            |  2 +-
>  drivers/scsi/sg.c                  |  6 +++---
>  drivers/scsi/st.c                  |  4 ++--
>  drivers/scsi/ufs/ufshcd.c          |  6 +++---
>  drivers/target/target_core_pscsi.c |  4 ++--
>  fs/nfsd/blocklayout.c              |  4 ++--
>  include/linux/blkdev.h             |  1 -
>  29 files changed, 46 insertions(+), 53 deletions(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index fc60ff208497..1754f5e7cc80 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -642,12 +642,6 @@ struct request *blk_get_request(struct request_queue *q, unsigned int op,
>  }
>  EXPORT_SYMBOL(blk_get_request);
>  
> -void blk_put_request(struct request *req)
> -{
> -	blk_mq_free_request(req);
> -}
> -EXPORT_SYMBOL(blk_put_request);

blk_get_request() still exists after this patch. A "get" API usually has
a corresponding "put" API. I'm not sure this patch helps the consistency
and clarity of the code.

If you do go ahead, please update the blk_get_request() doc comment
explicitly mentioning that blk_mq_free_request() needs to be called.

Stefan

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 97 bytes --]

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel