From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will@kernel.org>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Mark Rutland <mark.rutland@arm.com>, Pavel Machek <pavel@ucw.cz>,
Mike Snitzer <snitzer@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
kgdb-bugreport@lists.sourceforge.net,
Lai Jiangshan <jiangshanlai@gmail.com>,
Oleg Nesterov <oleg@redhat.com>, Ben Segall <bsegall@google.com>,
linux-mm@kvack.org, dm-devel@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
Zefan Li <lizefan.x@bytedance.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Joel Fernandes <joel@joelfernandes.org>,
netdev@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Alasdair Kergon <agk@redhat.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Vincent Guittot <vincent.guittot@linaro.org>,
kvm@vger.kernel.org, cgroups@vger.kernel.org, x86@kernel.org,
Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
Jakub Kicinski <kuba@kernel.org>,
John Stultz <john.stultz@linaro.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
linux-pm@vger.kernel.org, Boqun Feng <boqun.feng@gmail.com>,
Jason Wessel <jason.wessel@windriver.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Waiman Long <longman@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Jens Axboe <axboe@kernel.dk>, Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
rcu@vger.kernel.org,
Daniel Bristot de Oliveira <bristot@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [dm-devel] [PATCH 2/6] sched: Introduce task_is_running()
Date: Wed, 2 Jun 2021 18:46:16 +0200 [thread overview]
Message-ID: <YLe12Ba4CrvhMhFI@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210602145921.GB31179@willie-the-truck>
On Wed, Jun 02, 2021 at 03:59:21PM +0100, Will Deacon wrote:
> On Wed, Jun 02, 2021 at 03:12:27PM +0200, Peter Zijlstra wrote:
> > Replace a bunch of 'p->state == TASK_RUNNING' with a new helper:
> > task_is_running(p).
> >
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > ---
> > arch/x86/kernel/process.c | 4 ++--
> > block/blk-mq.c | 2 +-
> > include/linux/sched.h | 2 ++
> > kernel/locking/lockdep.c | 2 +-
> > kernel/rcu/tree_plugin.h | 2 +-
> > kernel/sched/core.c | 6 +++---
> > kernel/sched/stats.h | 2 +-
> > kernel/signal.c | 2 +-
> > kernel/softirq.c | 3 +--
> > mm/compaction.c | 2 +-
> > 10 files changed, 14 insertions(+), 13 deletions(-)
> >
> > --- a/arch/x86/kernel/process.c
> > +++ b/arch/x86/kernel/process.c
> > @@ -931,7 +931,7 @@ unsigned long get_wchan(struct task_stru
> > unsigned long start, bottom, top, sp, fp, ip, ret = 0;
> > int count = 0;
> >
> > - if (p == current || p->state == TASK_RUNNING)
> > + if (p == current || task_is_running(p))
>
> Looks like this one in get_wchan() has been cargo-culted across most of
> arch/ so they'll need fixing up before you rename the struct member.
Yeah, this was x86_64 allmodconfig driven, I've already got a bunch of
robot mail telling me other archs need help, I'll fix it iup.
> There's also a weird one in tools/bpf/runqslower/runqslower.bpf.c (!)
I'm tempted to let the bpf people sort their own gunk. This is not an
ABI. I so don't care breaking every script out there.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-06-03 6:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 13:12 [dm-devel] [PATCH 0/6] sched: Cleanup task_struct::state Peter Zijlstra
2021-06-02 13:12 ` [dm-devel] [PATCH 1/6] sched: Unbreak wakeups Peter Zijlstra
2021-06-02 13:58 ` Greg Kroah-Hartman
2021-06-02 14:47 ` Will Deacon
2021-06-02 19:43 ` Davidlohr Bueso
2021-06-02 13:12 ` [dm-devel] [PATCH 2/6] sched: Introduce task_is_running() Peter Zijlstra
2021-06-02 14:59 ` Will Deacon
2021-06-02 16:46 ` Peter Zijlstra [this message]
2021-06-02 23:15 ` Davidlohr Bueso
2021-06-02 13:12 ` [dm-devel] [PATCH 3/6] sched,perf,kvm: Fix preemption condition Peter Zijlstra
2021-06-02 13:59 ` [dm-devel] [PATCH 3/6] sched, perf, kvm: " Mathieu Desnoyers
2021-06-02 14:10 ` Peter Zijlstra
2021-06-02 14:30 ` Mark Rutland
2021-06-02 14:15 ` Mathieu Desnoyers
2021-06-02 14:23 ` Peter Zijlstra
2021-06-02 13:12 ` [dm-devel] [PATCH 4/6] sched: Add get_current_state() Peter Zijlstra
2021-06-02 14:01 ` Mathieu Desnoyers
2021-06-02 14:12 ` Peter Zijlstra
2021-06-02 15:02 ` Will Deacon
2021-06-02 13:12 ` [dm-devel] [PATCH 5/6] sched,timer: Use __set_current_state() Peter Zijlstra
2021-06-02 15:06 ` Will Deacon
2021-06-02 19:54 ` Davidlohr Bueso
2021-06-03 6:39 ` Peter Zijlstra
2021-06-18 20:42 ` Thomas Gleixner
2021-06-02 13:12 ` [dm-devel] [PATCH 6/6] sched: Change task_struct::state Peter Zijlstra
2021-06-02 14:06 ` Mathieu Desnoyers
2021-06-02 14:20 ` Peter Zijlstra
2021-06-02 15:10 ` Will Deacon
2021-06-07 10:45 ` Daniel Thompson
2021-06-07 11:10 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLe12Ba4CrvhMhFI@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=dietmar.eggemann@arm.com \
--cc=dm-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=jason.wessel@windriver.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=john.stultz@linaro.org \
--cc=jolsa@redhat.com \
--cc=josh@joshtriplett.org \
--cc=juri.lelli@redhat.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=pavel@ucw.cz \
--cc=pbonzini@redhat.com \
--cc=rcu@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=snitzer@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).