From: Luis Chamberlain <mcgrof@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: ulf.hansson@linaro.org, snitzer@redhat.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, agk@redhat.com, beanhuo@micron.com,
ming.lei@redhat.com, sagi@grimberg.me,
linux-scsi@vger.kernel.org, jejb@linux.ibm.com,
josef@toxicpanda.com, nbd@other.debian.org,
linux-block@vger.kernel.org, avri.altman@wdc.com,
kbusch@kernel.org, swboyd@chromium.org, bvanassche@acm.org,
axboe@kernel.dk, martin.petersen@oracle.com,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com
Subject: Re: [dm-devel] [PATCH 05/10] nvme: add error handling support for add_disk()
Date: Fri, 27 Aug 2021 11:32:52 -0700 [thread overview]
Message-ID: <YSkv1GtmFgvQ81Up@bombadil.infradead.org> (raw)
In-Reply-To: <YSSNIaYpUhrkvC+J@infradead.org>
On Tue, Aug 24, 2021 at 07:09:37AM +0100, Christoph Hellwig wrote:
> On Mon, Aug 23, 2021 at 01:29:25PM -0700, Luis Chamberlain wrote:
> > + rc = device_add_disk(ctrl->device, ns->disk, nvme_ns_id_attr_groups);
> > + if (rc)
> > + goto out_cleanup_ns_from_list;
> > +
>
> Nit: no real need for the rc variable here as we never use the actual
> value.
Alrighty.
> > if (!nvme_ns_head_multipath(ns->head))
> > nvme_add_ns_cdev(ns);
> >
> > @@ -3785,6 +3789,10 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid,
> >
> > return;
> >
> > + out_cleanup_ns_from_list:
> > + down_write(&ctrl->namespaces_rwsem);
> > + list_del_init(&ns->list);
> > + up_write(&ctrl->namespaces_rwsem);
>
> This also needs to do a nvme_put_ctrl.
Fixed.
Luis
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-08-27 18:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 20:29 [dm-devel] [PATCH 00/10] block: first batch of add_disk() error handling conversions Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk() Luis Chamberlain
2021-08-24 5:52 ` Christoph Hellwig
2021-08-27 18:27 ` Luis Chamberlain
2021-08-28 7:26 ` Christoph Hellwig
2021-08-23 20:29 ` [dm-devel] [PATCH 02/10] scsi/sd: add error handling support for add_disk() Luis Chamberlain
2021-08-24 5:58 ` Christoph Hellwig
2021-08-23 20:29 ` [dm-devel] [PATCH 03/10] scsi/sr: use blk_cleanup_disk() instead of put_disk() Luis Chamberlain
2021-08-24 6:00 ` Christoph Hellwig
2021-08-27 18:28 ` Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] [PATCH 04/10] scsi/sr: add error handling support for add_disk() Luis Chamberlain
2021-08-24 6:04 ` Christoph Hellwig
2021-08-23 20:29 ` [dm-devel] [PATCH 05/10] nvme: " Luis Chamberlain
2021-08-24 6:09 ` Christoph Hellwig
2021-08-27 18:32 ` Luis Chamberlain [this message]
2021-08-23 20:29 ` [dm-devel] [PATCH 06/10] mmc/core/block: " Luis Chamberlain
2021-08-24 6:13 ` Christoph Hellwig
2021-08-27 18:42 ` Luis Chamberlain
2021-08-28 7:32 ` Christoph Hellwig
2021-08-30 20:42 ` Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] [PATCH 07/10] md: " Luis Chamberlain
2021-08-24 6:15 ` Christoph Hellwig
2021-08-23 20:29 ` [dm-devel] [PATCH 08/10] dm: add add_disk() error handling Luis Chamberlain
2021-08-24 6:21 ` Christoph Hellwig
2021-08-27 18:55 ` Luis Chamberlain
2021-08-28 7:35 ` Christoph Hellwig
2021-08-30 21:00 ` Luis Chamberlain
2021-08-23 20:29 ` [dm-devel] [PATCH 09/10] loop: add error handling support for add_disk() Luis Chamberlain
2021-08-24 6:25 ` Christoph Hellwig
2021-08-23 20:29 ` [dm-devel] [PATCH 10/10] nbd: " Luis Chamberlain
2021-08-24 6:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSkv1GtmFgvQ81Up@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=agk@redhat.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).