dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org,
	Satya Tangirala <satyaprateek2357@gmail.com>,
	dm-devel@redhat.com, linux-mmc@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 3/5] blk-crypto: rename keyslot-manager files to blk-crypto-profile
Date: Wed, 15 Sep 2021 10:40:53 -0700	[thread overview]
Message-ID: <YUIwJQT9CnIoT7WO@sol.localdomain> (raw)
In-Reply-To: <YUGkfDmGa3WKz8cD@infradead.org>

On Wed, Sep 15, 2021 at 08:45:00AM +0100, Christoph Hellwig wrote:
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> It would be nice to keep the blk-crypto* includes together, though.

I don't see any case in which they aren't together.  Unless you're talking about
blk-crypto-internal.h, which is a directory-local header so it doesn't get
grouped with the <linux/*.h> headers.

- Eric

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-09-15 17:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  1:31 [dm-devel] [PATCH 0/5] blk-crypto cleanups Eric Biggers
2021-09-13  1:31 ` [dm-devel] [PATCH 1/5] blk-crypto-fallback: properly prefix function and struct names Eric Biggers
2021-09-15  7:36   ` Christoph Hellwig
2021-09-13  1:31 ` [dm-devel] [PATCH 2/5] blk-crypto-fallback: consolidate static variables Eric Biggers
2021-09-15  7:39   ` Christoph Hellwig
2021-09-15 17:50     ` Eric Biggers
2021-09-16  7:39       ` Christoph Hellwig
2021-09-16 17:28         ` Eric Biggers
2021-09-13  1:31 ` [dm-devel] [PATCH 3/5] blk-crypto: rename keyslot-manager files to blk-crypto-profile Eric Biggers
2021-09-14  9:04   ` Ulf Hansson
2021-09-15  7:45   ` Christoph Hellwig
2021-09-15 17:40     ` Eric Biggers [this message]
2021-09-16  7:42       ` Christoph Hellwig
2021-09-13  1:31 ` [dm-devel] [PATCH 4/5] blk-crypto: rename blk_keyslot_manager to blk_crypto_profile Eric Biggers
2021-09-14  9:04   ` Ulf Hansson
2021-09-14 21:52   ` Eric Biggers
2021-09-13  1:31 ` [dm-devel] [PATCH 5/5] blk-crypto: update inline encryption documentation Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUIwJQT9CnIoT7WO@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=satyaprateek2357@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).