From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Satya Tangirala <satyaprateek2357@gmail.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mmc@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH 2/5] blk-crypto-fallback: consolidate static variables
Date: Thu, 16 Sep 2021 08:39:54 +0100 [thread overview]
Message-ID: <YUL0ytosYfrs7nNi@infradead.org> (raw)
In-Reply-To: <YUIyVajIjZdkPO7F@sol.localdomain>
On Wed, Sep 15, 2021 at 10:50:13AM -0700, Eric Biggers wrote:
> Using "blk_crypto_fallback_*" for all these variables results in some pretty
> long names, e.g. "blk_crypto_fallback_crypt_ctx_cache" and
> "blk_crypto_fallback_num_prealloc_crypt_ctxs". This proposal gives the best of
> both worlds; the names are properly "namespaced" but there is also a shortcut to
> refer to them (struct blk_crypto_fallback *fallback = &blk_crypto_fallback).
I'd just drop the second crypt in those.
> If this is going to be controversial I can just drop this patch, but I was
> hoping there would be a way to make things more consistent.
I personally detest that pattern. Not sure if that counts as
controversial or even matters :)
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-09-16 7:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 1:31 [dm-devel] [PATCH 0/5] blk-crypto cleanups Eric Biggers
2021-09-13 1:31 ` [dm-devel] [PATCH 1/5] blk-crypto-fallback: properly prefix function and struct names Eric Biggers
2021-09-15 7:36 ` Christoph Hellwig
2021-09-13 1:31 ` [dm-devel] [PATCH 2/5] blk-crypto-fallback: consolidate static variables Eric Biggers
2021-09-15 7:39 ` Christoph Hellwig
2021-09-15 17:50 ` Eric Biggers
2021-09-16 7:39 ` Christoph Hellwig [this message]
2021-09-16 17:28 ` Eric Biggers
2021-09-13 1:31 ` [dm-devel] [PATCH 3/5] blk-crypto: rename keyslot-manager files to blk-crypto-profile Eric Biggers
2021-09-14 9:04 ` Ulf Hansson
2021-09-15 7:45 ` Christoph Hellwig
2021-09-15 17:40 ` Eric Biggers
2021-09-16 7:42 ` Christoph Hellwig
2021-09-13 1:31 ` [dm-devel] [PATCH 4/5] blk-crypto: rename blk_keyslot_manager to blk_crypto_profile Eric Biggers
2021-09-14 9:04 ` Ulf Hansson
2021-09-14 21:52 ` Eric Biggers
2021-09-13 1:31 ` [dm-devel] [PATCH 5/5] blk-crypto: update inline encryption documentation Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUL0ytosYfrs7nNi@infradead.org \
--to=hch@infradead.org \
--cc=dm-devel@redhat.com \
--cc=ebiggers@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyaprateek2357@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).