From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FBFAC74A5B for ; Wed, 29 Mar 2023 23:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680132748; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cSPjXR4OsrdrF0jVxdGNVqmTCqnOxmAPTzTGd5oQgDY=; b=GW5pDhtdL/DZRIXFF7DnAathjPOoVm6mA1DwRwShBL1OuF5T7cmY3P79Zk+KIDhOzntnVR TBvJENnqm5/lvbk/FsJoxGfr8TDzkOZr4OBzMwlSOeliA1KTnA7aU3VFefCHW6ySL8Qhet Z07w+nUWdcCeEREFbOkXJ/pEPEhSD58= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-531-j5BoXiz3NpmK4_TmtEnQ0A-1; Wed, 29 Mar 2023 19:32:24 -0400 X-MC-Unique: j5BoXiz3NpmK4_TmtEnQ0A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A1958030CD; Wed, 29 Mar 2023 23:32:23 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05AC814171BB; Wed, 29 Mar 2023 23:32:23 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B8C74194658C; Wed, 29 Mar 2023 23:32:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EF7E11946587 for ; Wed, 29 Mar 2023 23:32:21 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id D94AB40BC798; Wed, 29 Mar 2023 23:32:21 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D21D440BC797 for ; Wed, 29 Mar 2023 23:32:21 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B55C685A5A3 for ; Wed, 29 Mar 2023 23:32:21 +0000 (UTC) Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-269-Hgmg0KOxNIyCE_TUOXvR0Q-2; Wed, 29 Mar 2023 19:32:19 -0400 X-MC-Unique: Hgmg0KOxNIyCE_TUOXvR0Q-2 X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="225113558" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:32:18 +0800 IronPort-SDR: Tfh6u61B63jfInA2VdntIUxHX5qr1Foff2lh4EAKbTCKaJ6eZcpQ9P+TeteFZ+2f+LgoIpt+RI xZZwpdbDUvmLQmICtnAeD8XVy+yoBamFOxkBKn2hwtRasIRO9RI4ukOOQW35ncgRKg3mQRovnq yt4IxxOKyTLAdJfV2+1jwVBjWXdIIqQXfgcEXNhbIsEgj9ciBU19CWssz2QmOZuIP9Gzv0VdSH m1eN8ql8UBYqbPByXVdFiNzV6dW49pq7+OJitA6YzKMiouOfchtbcI8jWRloO3A1GxpJ4sbMED jWg= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:48:26 -0700 IronPort-SDR: gyjMtgtA7KkCIQQgs9UBCMOW0lIekWQC7MnMtvckO7mPpdgl0C7mf1Do/abyIFIClqOI+ZVRl6 eJQaAE2XBFyPQrG/vKHwTvzwCQ32Q1E5YSvU5gJrceuGIDr4fzF+4aUzuRsufWFE0no49oFeLY Fw2F2TqWCBvF5YXNUu1MDgg5sixlPpXQkghUSkJEbEp5VqaE+hXDVyuLPawtn4GIpwvBS1Gknt ZVV4XLjmstyDycTFy00LHI+3A4jIT5Mwt6VSpMgdoagijw6BwsbIIM7y+EuQaVx136BUZMuZX8 vkE= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:32:18 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2rx6YHkz1RtVp for ; Wed, 29 Mar 2023 16:32:17 -0700 (PDT) X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NNHi05S-GcsM for ; Wed, 29 Mar 2023 16:32:17 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2rt2gL4z1RtVm; Wed, 29 Mar 2023 16:32:14 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:32:13 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Johannes Thumshirn , Jens Axboe References: <492cbaf4225065838d25e04f8488528e50a52e3e.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <492cbaf4225065838d25e04f8488528e50a52e3e.1680108414.git.johannes.thumshirn@wdc.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Subject: Re: [dm-devel] [PATCH 06/19] md: raid5-log: use __bio_add_page to add single page X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-raid@vger.kernel.org, jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Chaitanya Kulkarni , Andreas Gruenbacher , Song Liu , Dave Kleikamp , Mike Snitzer , Matthew Wilcox , Ming Lei , linux-block@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, David Sterba , linux-fsdevel@vger.kernel.org, Christoph Hellwig , linux-btrfs@vger.kernel.org, Bob Peterson Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: opensource.wdc.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 3/30/23 02:05, Johannes Thumshirn wrote: > The raid5 log metadata submission code uses bio_add_page() to add a page > to a newly created bio. bio_add_page() can fail, but the return value is > never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel