From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 068C6C433B4 for ; Fri, 14 May 2021 09:45:02 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BE2B6141E for ; Fri, 14 May 2021 09:45:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BE2B6141E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620985500; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TppqU1NAaFj4p5YYwXR6Q0RpNOtJEcyOU63MNOR0lIk=; b=E5yN/7BF/AGLpPhQO0W43TIAO+TLjg3ltnPLoCQ0no6hVnN2WLeyoUWTkRHy1Fg/oT5GbP nTAMtM4yTI6/Cn75ulhn9NxDoovVpdMq0VoNDm/jEaPvCM/isSdC2Q7aLxEbQDHcOSTPtj uO9N1Je1VU89VDen0pdTewPXrRhF9To= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-YWLl353CPVy2qubcthEeKQ-1; Fri, 14 May 2021 05:44:58 -0400 X-MC-Unique: YWLl353CPVy2qubcthEeKQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7819100945E; Fri, 14 May 2021 09:44:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B6A05D9CD; Fri, 14 May 2021 09:44:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D85EE180B463; Fri, 14 May 2021 09:44:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14E9hoVx022349 for ; Fri, 14 May 2021 05:43:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1E8021050A; Fri, 14 May 2021 09:43:50 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A507F1971B; Fri, 14 May 2021 09:43:39 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id 14E9hd7S022799; Fri, 14 May 2021 05:43:39 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id 14E9haED022795; Fri, 14 May 2021 05:43:36 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Fri, 14 May 2021 05:43:36 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Bart Van Assche In-Reply-To: Message-ID: References: <0e7b0b6e-e78c-f22d-af8d-d7bdcb597bea@gmail.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: dm-devel@redhat.com Cc: axboe@kernel.dk, ming.lei@redhat.com, Theodore Ts'o , bgoncalv@redhat.com, dm-crypt@saout.de, yi.zhang@redhat.com, linux-kernel@vger.kernel.org, alex_y_xu@yahoo.ca, hch@lst.de, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, Changheun Lee , jaegeuk@kernel.org, linux-ext4@vger.kernel.org, Milan Broz Subject: Re: [dm-devel] regression: data corruption with ext4 on LUKS on nvme with torvalds master X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 13 May 2021, Bart Van Assche wrote: > On 5/13/21 12:22 PM, Mikulas Patocka wrote: > > We already had problems with too large bios in dm-crypt and we fixed it by > > adding this piece of code: > > > > /* > > * Check if bio is too large, split as needed. > > */ > > if (unlikely(bio->bi_iter.bi_size > (BIO_MAX_VECS << PAGE_SHIFT)) && > > (bio_data_dir(bio) == WRITE || cc->on_disk_tag_size)) > > dm_accept_partial_bio(bio, ((BIO_MAX_VECS << PAGE_SHIFT) >> SECTOR_SHIFT)); > > > > It will ask the device mapper to split the bio if it is too large. So, > > crypt_alloc_buffer can't receive a bio that is larger than BIO_MAX_VECS << > > PAGE_SHIFT. > > Hi Mikulas, > > Are you perhaps referring to commit 4e870e948fba ("dm crypt: fix error > with too large bios")? Did that commit go upstream before multi-page > bvec support? Yes. It's from 2016. > Can larger bios be supported in case of two or more > contiguous pages now that multi-page bvec support is upstream? No - we need to allocate a buffer for the written data. The buffer size is limited to PAGE_SIZE * BIO_MAX_VECS. > Thanks, > > Bart. Mikulas -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel