From: Mikulas Patocka <mpatocka@redhat.com>
To: Mike Snitzer <msnitzer@redhat.com>
Cc: Heinz Mauelshagen <heinzm@redhat.com>,
dm-devel@redhat.com, Joe Thornber <thornber@redhat.com>
Subject: [dm-devel] [PATCH] dm-writecache: back off if the kcopyd workqueue is blocked
Date: Tue, 15 Jun 2021 13:47:47 -0400 (EDT) [thread overview]
Message-ID: <alpine.LRH.2.02.2106151346100.29600@file01.intranet.prod.int.rdu2.redhat.com> (raw)
This patch makes dm-writecache wait if the kcopyd workqueue is blocked (it
happens when one of the devices is contested). It improves performance of
"mkfs.ext2" by approximatelly 20%.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Index: linux/drivers/md/dm-kcopyd.c
===================================================================
--- linux.orig/drivers/md/dm-kcopyd.c
+++ linux/drivers/md/dm-kcopyd.c
@@ -888,6 +888,12 @@ void dm_kcopyd_do_callback(void *j, int
}
EXPORT_SYMBOL(dm_kcopyd_do_callback);
+void dm_kcopyd_wait_if_busy(struct dm_kcopyd_client *kc)
+{
+ flush_workqueue(kc->kcopyd_wq);
+}
+EXPORT_SYMBOL(dm_kcopyd_wait_if_busy);
+
/*
* Cancels a kcopyd job, eg. someone might be deactivating a
* mirror.
Index: linux/drivers/md/dm-writecache.c
===================================================================
--- linux.orig/drivers/md/dm-writecache.c
+++ linux/drivers/md/dm-writecache.c
@@ -1819,6 +1819,9 @@ static void writecache_writeback(struct
struct writeback_list wbl;
unsigned long n_walked;
+ if (!WC_MODE_PMEM(wc))
+ dm_kcopyd_wait_if_busy(wc->dm_kcopyd);
+
wc_lock(wc);
restart:
if (writecache_has_error(wc)) {
Index: linux/include/linux/dm-kcopyd.h
===================================================================
--- linux.orig/include/linux/dm-kcopyd.h
+++ linux/include/linux/dm-kcopyd.h
@@ -81,6 +81,8 @@ void *dm_kcopyd_prepare_callback(struct
dm_kcopyd_notify_fn fn, void *context);
void dm_kcopyd_do_callback(void *job, int read_err, unsigned long write_err);
+void dm_kcopyd_wait_if_busy(struct dm_kcopyd_client *kc);
+
void dm_kcopyd_zero(struct dm_kcopyd_client *kc,
unsigned num_dests, struct dm_io_region *dests,
unsigned flags, dm_kcopyd_notify_fn fn, void *context);
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next reply other threads:[~2021-06-15 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 17:47 Mikulas Patocka [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-06 20:08 [dm-devel] [PATCH] dm-writecache: back off if the kcopyd workqueue is blocked Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.02.2106151346100.29600@file01.intranet.prod.int.rdu2.redhat.com \
--to=mpatocka@redhat.com \
--cc=dm-devel@redhat.com \
--cc=heinzm@redhat.com \
--cc=msnitzer@redhat.com \
--cc=thornber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).