From: Martin Wilck <mwilck@suse.com>
To: Luca BRUNO <luca.bruno@coreos.com>, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH] multipathd.socket: add missing conditions from service unit
Date: Fri, 24 Sep 2021 14:27:00 +0200 [thread overview]
Message-ID: <cd2850ea37f4ea880717aab621d0c7a181e4c351.camel@suse.com> (raw)
In-Reply-To: <20210924093401.17852-1-luca.bruno@coreos.com>
On Fri, 2021-09-24 at 09:34 +0000, Luca BRUNO wrote:
> This aligns 'multipathd' socket and service units, by adding the
> start conditions that are set on the service but not on the socket.
> It should help avoiding situations where the socket unit ends up
> marked as failed after hitting its retry-limit.
>
> Fixes: https://github.com/opensvc/multipath-tools/issues/15
> Signed-off-by: Luca BRUNO <luca.bruno@coreos.com>
> ---
> multipathd/multipathd.socket | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git multipathd/multipathd.socket multipathd/multipathd.socket
> index 0ed4a1f7..c777e5e3 100644
> --- multipathd/multipathd.socket
> +++ multipathd/multipathd.socket
> @@ -1,6 +1,9 @@
> [Unit]
> Description=multipathd control socket
> DefaultDependencies=no
> +ConditionKernelCommandLine=!nompath
> +ConditionKernelCommandLine=!multipath=off
> +ConditionVirtualization=!container
> Before=sockets.target
>
> [Socket]
Thanks!
I'll apply this to
https://github.com/openSUSE/multipath-tools/tree/queue
>From there it'll be submitted to the main repo.
Reviewed-by: Martin Wilck <mwilck@suse.com>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2021-09-24 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:34 [dm-devel] [PATCH] multipathd.socket: add missing conditions from service unit Luca BRUNO
2021-09-24 12:27 ` Martin Wilck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd2850ea37f4ea880717aab621d0c7a181e4c351.camel@suse.com \
--to=mwilck@suse.com \
--cc=dm-devel@redhat.com \
--cc=luca.bruno@coreos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).