From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH v2 1/2] libmultipath: Allow discovery of USB devices Date: Sat, 26 Sep 2020 20:54:58 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Frank Meinl , dm-devel@redhat.com List-Id: dm-devel.ids On Sat, 2020-09-26 at 18:26 +0200, Frank Meinl wrote: > This change adds a new configuration option allow_usb_devices. It is > disabled by default, so that the behavior of existing setups is not > changed. If enabled (via multipath.conf), USB devices will be found > during device discovery and can be used for multipath setups. > > Without this option, multipath currently ignores all USB drives, > which > is convenient for most users. (refer also to commit 51957eb) > > However, it can be beneficial to use the multipath dm-module even if > there is only a single path to an USB attached storage. In > combination > with the option 'queue_if_no_path', such a setup survives a temporary > device disconnect without any severe consequences for the running > applications. All I/O is queued until the device reappears. > > Signed-off-by: Frank Meinl Sorry, I forgot in the previous review: You must add an entry for SCSI_PROTOCOL_USB in snprint_path_protocol(). Apart from that, this looks OK. Regards, Martin