From: yangerkun <yangerkun@huaweicloud.com>
To: Bart Van Assche <bvanassche@acm.org>,
agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com
Cc: yangerkun@huawei.com
Subject: Re: [dm-devel] [PATCH] dm-crypt: fix softlockup in dmcrypt_write
Date: Mon, 27 Feb 2023 09:31:04 +0800 [thread overview]
Message-ID: <e69ec125-3636-ab20-ce63-f4b89ac55ffb@huaweicloud.com> (raw)
In-Reply-To: <b7020147-2382-71f6-5237-8501562f8011@acm.org>
在 2023/2/26 10:01, Bart Van Assche 写道:
> On 2/22/23 19:19, yangerkun wrote:
>> @@ -1924,6 +1926,10 @@ static int dmcrypt_write(void *data)
>> BUG_ON(rb_parent(write_tree.rb_node));
>> + if (time_is_before_jiffies(start_time + HZ)) {
>> + schedule();
>> + start_time = jiffies;
>> + }
>
> Why schedule() instead of cond_resched()?
cond_resched may not really schedule, which may trigger the problem too,
but it seems after 1 second, it may never happend?
Thanks,
Kun.
>
> Thanks,
>
> Bart.
>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-02-27 7:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 3:19 [dm-devel] [PATCH] dm-crypt: fix softlockup in dmcrypt_write yangerkun
2023-02-26 2:01 ` Bart Van Assche
2023-02-27 1:31 ` yangerkun [this message]
2023-02-27 17:55 ` [dm-devel] " Mike Snitzer
2023-02-27 18:03 ` Mike Snitzer
2023-02-27 18:06 ` Mike Snitzer
2023-02-28 1:40 ` yangerkun
2023-03-06 18:02 ` Mikulas Patocka
2023-03-06 18:16 ` Bart Van Assche
2023-03-06 19:03 ` Mikulas Patocka
2023-02-28 1:25 ` yangerkun
2023-02-28 7:22 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e69ec125-3636-ab20-ce63-f4b89ac55ffb@huaweicloud.com \
--to=yangerkun@huaweicloud.com \
--cc=agk@redhat.com \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=snitzer@kernel.org \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).