From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EE1C433E0 for ; Thu, 21 Jan 2021 15:03:17 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D65F8235FF for ; Thu, 21 Jan 2021 15:03:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D65F8235FF Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-lmq5jEocPh2K8Js32tZYeQ-1; Thu, 21 Jan 2021 10:03:13 -0500 X-MC-Unique: lmq5jEocPh2K8Js32tZYeQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A5CD107ACE4; Thu, 21 Jan 2021 15:03:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 998F22CFAA; Thu, 21 Jan 2021 15:03:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E01564BB7B; Thu, 21 Jan 2021 15:03:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 10LF2xa9019724 for ; Thu, 21 Jan 2021 10:02:59 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8D8F62166B2A; Thu, 21 Jan 2021 15:02:59 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 88EA62166B2F for ; Thu, 21 Jan 2021 15:02:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5ABDC1875040 for ; Thu, 21 Jan 2021 15:02:56 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-24-M3q_Q0-FMM-qmqVAC8nZVg-1; Thu, 21 Jan 2021 10:02:54 -0500 X-MC-Unique: M3q_Q0-FMM-qmqVAC8nZVg-1 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AEE83ABD6; Thu, 21 Jan 2021 15:02:52 +0000 (UTC) Message-ID: From: Martin Wilck To: Mike Snitzer , Hannes Reinecke Date: Thu, 21 Jan 2021 16:02:52 +0100 In-Reply-To: <29294c6553c7ec3d31e1bc3b9de524e9c7060f07.camel@suse.com> References: <20201210092459.81939-1-hare@suse.de> <29294c6553c7ec3d31e1bc3b9de524e9c7060f07.camel@suse.com> User-Agent: Evolution 3.38.2 MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com Subject: Re: [dm-devel] [PATCH] dm: avoid filesystem lookup in dm_get_dev_t() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 2020-12-10 at 18:11 +0100, Martin Wilck wrote: > On Thu, 2020-12-10 at 10:24 +0100, Hannes Reinecke wrote: > > dm_get_dev_t() is just used to convert an arbitrary 'path' string > > into a dev_t. It doesn't presume that the device is present; that > > check will be done later, as the only caller is dm_get_device(), > > which does a dm_get_table_device() later on, which will properly > > open the device. > > So if the path string already _is_ in major:minor representation > > we can convert it directly, avoiding a recursion into the > > filesystem > > to lookup the block device. > > This avoids a hang in multipath_message() when the filesystem is > > inaccessible. > > > > Signed-off-by: Hannes Reinecke > > Ack, although I believe the scsi/__GENKSYMS__ part doesn't belong > here. > > Note that this is essentially a revert/fix of 644bda6f3460 ("dm > table: > fall back to getting device using name_to_dev_t()"). Added the author > of that patch to CC. Mike, do you need anything more to apply this one? Do you want a cleaned-up resend? Cheers, Martin -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel