dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [dm-devel] [PATCH] dm io: fix comments to align with on-stack plugging
@ 2021-07-17 15:54 Xianting Tian
  2021-07-24  2:31 ` Xianting Tian
  0 siblings, 1 reply; 2+ messages in thread
From: Xianting Tian @ 2021-07-17 15:54 UTC (permalink / raw)
  To: agk, snitzer; +Cc: Xianting Tian, dm-devel, linux-kernel

From: Xianting Tian <xianting.tian@linux.alibaba.com>

Ther is no unplugging timer now, on-stack io plugging is used:
	struct blk_plug plug;

	blk_start_plug(&plug);
	submit_batch_of_io();
	blk_finish_plug(&plug);

So remove the old comments for unplugging timer.

Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
 drivers/md/dm-io.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
index 2d3cda0..7dba193 100644
--- a/drivers/md/dm-io.c
+++ b/drivers/md/dm-io.c
@@ -528,11 +528,6 @@ static int dp_init(struct dm_io_request *io_req, struct dpages *dp,
 
 /*
  * New collapsed (a)synchronous interface.
- *
- * If the IO is asynchronous (i.e. it has notify.fn), you must either unplug
- * the queue with blk_unplug() some time later or set REQ_SYNC in
- * io_req->bi_opf. If you fail to do one of these, the IO will be submitted to
- * the disk after q->unplug_delay, which defaults to 3ms in blk-settings.c.
  */
 int dm_io(struct dm_io_request *io_req, unsigned num_regions,
 	  struct dm_io_region *where, unsigned long *sync_error_bits)
-- 
1.8.3.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [dm-devel] [PATCH] dm io: fix comments to align with on-stack plugging
  2021-07-17 15:54 [dm-devel] [PATCH] dm io: fix comments to align with on-stack plugging Xianting Tian
@ 2021-07-24  2:31 ` Xianting Tian
  0 siblings, 0 replies; 2+ messages in thread
From: Xianting Tian @ 2021-07-24  2:31 UTC (permalink / raw)
  To: agk, snitzer; +Cc: dm-devel, linux-kernel

Could I get the comments for the patch?  thanks

在 2021/7/17 下午11:54, Xianting Tian 写道:
> From: Xianting Tian <xianting.tian@linux.alibaba.com>
>
> Ther is no unplugging timer now, on-stack io plugging is used:
> 	struct blk_plug plug;
>
> 	blk_start_plug(&plug);
> 	submit_batch_of_io();
> 	blk_finish_plug(&plug);
>
> So remove the old comments for unplugging timer.
>
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> ---
>   drivers/md/dm-io.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
> index 2d3cda0..7dba193 100644
> --- a/drivers/md/dm-io.c
> +++ b/drivers/md/dm-io.c
> @@ -528,11 +528,6 @@ static int dp_init(struct dm_io_request *io_req, struct dpages *dp,
>   
>   /*
>    * New collapsed (a)synchronous interface.
> - *
> - * If the IO is asynchronous (i.e. it has notify.fn), you must either unplug
> - * the queue with blk_unplug() some time later or set REQ_SYNC in
> - * io_req->bi_opf. If you fail to do one of these, the IO will be submitted to
> - * the disk after q->unplug_delay, which defaults to 3ms in blk-settings.c.
>    */
>   int dm_io(struct dm_io_request *io_req, unsigned num_regions,
>   	  struct dm_io_region *where, unsigned long *sync_error_bits)

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-26  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-17 15:54 [dm-devel] [PATCH] dm io: fix comments to align with on-stack plugging Xianting Tian
2021-07-24  2:31 ` Xianting Tian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).