From: Randy Dunlap <rdunlap@infradead.org>
To: "Mehta, Sanju" <Sanju.Mehta@amd.com>,
"S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
"Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@amd.com>,
"Kumar, Rajesh" <Rajesh1.Kumar@amd.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh@kernel.org" <robh@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: Re: [PATCH 1/4] dma: Add PTDMA Engine driver support
Date: Tue, 24 Sep 2019 07:35:56 -0700 [thread overview]
Message-ID: <064f3abe-7d6c-0ab3-1362-61ba6b09840e@infradead.org> (raw)
In-Reply-To: <1569310272-29153-1-git-send-email-Sanju.Mehta@amd.com>
On 9/24/19 12:31 AM, Mehta, Sanju wrote:
> From: Sanjay R Mehta <sanju.mehta@amd.com>
>
> This is the driver for the AMD passthrough DMA Engine
>
> Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
> Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Reviewed-by: Rajesh Kumar <Rajesh1.Kumar@amd.com>
> ---
> diff --git a/drivers/dma/ptdma/Kconfig b/drivers/dma/ptdma/Kconfig
> new file mode 100644
> index 0000000..a373431
> --- /dev/null
> +++ b/drivers/dma/ptdma/Kconfig
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config AMD_PTDMA
> + tristate "AMD Passthru DMA Engine"
> + default m
Can you justify "default m"? Most likely it should not be here.
> + depends on X86_64 && PCI
> + help
> + Provides the support for AMD Passthru DMA engine.
--
~Randy
next prev parent reply other threads:[~2019-09-24 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 7:31 [PATCH 1/4] dma: Add PTDMA Engine driver support Mehta, Sanju
2019-09-24 14:35 ` Randy Dunlap [this message]
2019-10-03 17:24 ` Sanjay R Mehta
2019-09-24 19:12 ` Vinod Koul
2019-10-03 17:37 ` Sanjay R Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=064f3abe-7d6c-0ab3-1362-61ba6b09840e@infradead.org \
--to=rdunlap@infradead.org \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Rajesh1.Kumar@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).