* [PATCH] dmaengine: idxd: depends on !UML
@ 2021-06-25 8:38 Johannes Berg
2021-06-25 9:14 ` Anton Ivanov
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Johannes Berg @ 2021-06-25 8:38 UTC (permalink / raw)
To: dmaengine; +Cc: Dave Jiang, linux-um, Johannes Berg, kernel test robot
From: Johannes Berg <johannes.berg@intel.com>
Now that UML has PCI support, this driver must depend also on
!UML since it pokes at X86_64 architecture internals that don't
exist on ARCH=um.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/dma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 6ab9d9a488a6..1f3c0e2ea4d9 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -278,7 +278,7 @@ config INTEL_IDMA64
config INTEL_IDXD
tristate "Intel Data Accelerators support"
- depends on PCI && X86_64
+ depends on PCI && X86_64 && !UML
depends on PCI_MSI
depends on SBITMAP
select DMA_ENGINE
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dmaengine: idxd: depends on !UML
2021-06-25 8:38 [PATCH] dmaengine: idxd: depends on !UML Johannes Berg
@ 2021-06-25 9:14 ` Anton Ivanov
2021-06-25 14:34 ` Dave Jiang
2021-07-14 7:00 ` Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Anton Ivanov @ 2021-06-25 9:14 UTC (permalink / raw)
To: Johannes Berg, dmaengine
Cc: Dave Jiang, linux-um, Johannes Berg, kernel test robot
On 25/06/2021 09:38, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Now that UML has PCI support, this driver must depend also on
> !UML since it pokes at X86_64 architecture internals that don't
> exist on ARCH=um.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/dma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 6ab9d9a488a6..1f3c0e2ea4d9 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -278,7 +278,7 @@ config INTEL_IDMA64
>
> config INTEL_IDXD
> tristate "Intel Data Accelerators support"
> - depends on PCI && X86_64
> + depends on PCI && X86_64 && !UML
> depends on PCI_MSI
> depends on SBITMAP
> select DMA_ENGINE
>
Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dmaengine: idxd: depends on !UML
2021-06-25 8:38 [PATCH] dmaengine: idxd: depends on !UML Johannes Berg
2021-06-25 9:14 ` Anton Ivanov
@ 2021-06-25 14:34 ` Dave Jiang
2021-07-14 7:00 ` Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Dave Jiang @ 2021-06-25 14:34 UTC (permalink / raw)
To: Johannes Berg, dmaengine; +Cc: linux-um, Johannes Berg, kernel test robot
On 6/25/2021 1:38 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Now that UML has PCI support, this driver must depend also on
> !UML since it pokes at X86_64 architecture internals that don't
> exist on ARCH=um.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 6ab9d9a488a6..1f3c0e2ea4d9 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -278,7 +278,7 @@ config INTEL_IDMA64
>
> config INTEL_IDXD
> tristate "Intel Data Accelerators support"
> - depends on PCI && X86_64
> + depends on PCI && X86_64 && !UML
> depends on PCI_MSI
> depends on SBITMAP
> select DMA_ENGINE
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dmaengine: idxd: depends on !UML
2021-06-25 8:38 [PATCH] dmaengine: idxd: depends on !UML Johannes Berg
2021-06-25 9:14 ` Anton Ivanov
2021-06-25 14:34 ` Dave Jiang
@ 2021-07-14 7:00 ` Vinod Koul
2021-08-09 9:21 ` Johannes Berg
2 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2021-07-14 7:00 UTC (permalink / raw)
To: Johannes Berg
Cc: dmaengine, Dave Jiang, linux-um, Johannes Berg, kernel test robot
On 25-06-21, 10:38, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Now that UML has PCI support, this driver must depend also on
> !UML since it pokes at X86_64 architecture internals that don't
> exist on ARCH=um.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dmaengine: idxd: depends on !UML
2021-07-14 7:00 ` Vinod Koul
@ 2021-08-09 9:21 ` Johannes Berg
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2021-08-09 9:21 UTC (permalink / raw)
To: Vinod Koul; +Cc: dmaengine, Dave Jiang, linux-um, kernel test robot
On Wed, 2021-07-14 at 12:30 +0530, Vinod Koul wrote:
> On 25-06-21, 10:38, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > Now that UML has PCI support, this driver must depend also on
> > !UML since it pokes at X86_64 architecture internals that don't
> > exist on ARCH=um.
>
> Applied, thanks
Thanks.
Any reason this hasn't landed in Linus's tree yet? I keep getting build
failure reports from there.
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-09 9:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-25 8:38 [PATCH] dmaengine: idxd: depends on !UML Johannes Berg
2021-06-25 9:14 ` Anton Ivanov
2021-06-25 14:34 ` Dave Jiang
2021-07-14 7:00 ` Vinod Koul
2021-08-09 9:21 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).