From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Felipe Balbi <balbi@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org,
Felipe Balbi <felipe.balbi@microsoft.com>
Subject: Re: [PATCH 2/2] arm64: boot: dts: qcom: sm8150: Add DMA nodes
Date: Fri, 16 Apr 2021 20:56:03 +0200 [thread overview]
Message-ID: <0bb8e50d-9ea1-f616-6493-20fcb4e09e31@somainline.org> (raw)
In-Reply-To: <20210416133133.2067467-3-balbi@kernel.org>
>one little note. This was for a quick test. I can either remove, keep it
>or complete with the rest of the SPIs in this same patch. Let me know
>what y'all prefer :-)
Yeah, please remove it from this one and send in a separate patch, preferably adding dmas to all the QUPs :)
Aaand since I already asked you to re-send, you might as well fix up the properties order under the nodes (compatible first, then reg, with #dma-cells somewhere at the bottom) and the unit name (should be "dma-controller@...").
Konrad
next prev parent reply other threads:[~2021-04-16 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 13:31 [PATCH 0/2] arm64: sm8150: Add minimal DMA support Felipe Balbi
2021-04-16 13:31 ` [PATCH 1/2] DMA: qcom: gpi: add compatible for sm8150 Felipe Balbi
2021-04-16 13:31 ` [PATCH 2/2] arm64: boot: dts: qcom: sm8150: Add DMA nodes Felipe Balbi
2021-04-16 13:40 ` Felipe Balbi
2021-04-16 18:56 ` Konrad Dybcio [this message]
2021-04-17 6:20 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bb8e50d-9ea1-f616-6493-20fcb4e09e31@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=felipe.balbi@microsoft.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).