From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Linus Walleij <linus.ml.walleij@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Vinod Koul <vkoul@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6
Date: Tue, 25 Feb 2020 08:01:46 +0000 [thread overview]
Message-ID: <109d4a9e-a862-fd81-9562-0a6d1e8406da@kontron.de> (raw)
In-Reply-To: <CAOMZO5CyYbAZRZrGLJNJXNJiekJXptUTu8tOfVw6y7-n-CXesg@mail.gmail.com>
Hi Fabio,
On 24.02.20 19:43, Fabio Estevam wrote:
> Hi Frieder,
>
> On Mon, Feb 24, 2020 at 2:22 PM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
>>
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> On i.MX6 the DMA event for the RX channel of UART6 is '0'. To fix
>
> I would suggest being a bit more specific than saying i.MX6.
>
> I see UART6 is present on i.MX6UL/i.MX6SX, but not on i.MX6Q/i.MX6DL,
> so it would be better to specify it in the commit log.
>
> imx6ul.dtsi does not have dma nodes under uart6, so I guess you fixed
> it for imx6sx.
Sounds reasonable. I will change the commit message to refer to
i.MX6UL/ULL/SX.
Actually one of our customers has a dts for i.MX6UL, that enables the
DMA for UART6. The DMA not being enabled in imx6ul.dtsi doesn't mean no
one is using it. Actually I have no idea why it's enabled by default for
i.MX6SX and disabled by default for i.MX6UL.
Thanks,
Frieder
>
>> the broken DMA support for UART6, we change the check for event_id0
>> to include '0' as a valid id.
>>
>> Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
next prev parent reply other threads:[~2020-02-25 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 17:22 [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6 Schrempf Frieder
2020-02-24 18:43 ` Fabio Estevam
2020-02-25 6:12 ` Vinod Koul
2020-02-25 8:03 ` Schrempf Frieder
2020-02-25 8:01 ` Schrempf Frieder [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-24 17:16 Schrempf Frieder
2020-02-24 17:22 ` Schrempf Frieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=109d4a9e-a862-fd81-9562-0a6d1e8406da@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).