From: Lucas Stach <l.stach@pengutronix.de>
To: Robin Gong <yibin.gong@nxp.com>,
vkoul@kernel.org, mark.rutland@arm.com, broonie@kernel.org,
robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com,
shawnguo@kernel.org, festevam@gmail.com, s.hauer@pengutronix.de,
martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de,
dan.j.williams@intel.com, matthias.schiffer@ew.tq-group.com,
frieder.schrempf@kontron.de, m.felsch@pengutronix.de,
xiaoning.wang@nxp.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v16 09/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul
Date: Wed, 14 Jul 2021 10:17:59 +0200 [thread overview]
Message-ID: <152cb353c4c6fe66ba40c084cd62947967080011.camel@pengutronix.de> (raw)
In-Reply-To: <1626258052-22198-10-git-send-email-yibin.gong@nxp.com>
Am Mittwoch, dem 14.07.2021 um 18:20 +0800 schrieb Robin Gong:
> ECSPI issue fixed from i.mx6ul at hardware level, no need
> ERR009165 anymore on those chips such as i.mx8mq.
>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> Acked-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/dma/imx-sdma.c | 26 ++++++++++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 5969df8..cfcd413 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -476,6 +476,13 @@ struct sdma_driver_data {
> int num_events;
> struct sdma_script_start_addrs *script_addrs;
> bool check_ratio;
> + /*
> + * ecspi ERR009165 fixed should be done in sdma script
> + * and it has been fixed in soc from i.mx6ul.
> + * please get more information from the below link:
> + * https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf
> + */
> + bool ecspi_fixed;
> };
>
> struct sdma_engine {
> @@ -596,6 +603,13 @@ static struct sdma_driver_data sdma_imx6q = {
> .script_addrs = &sdma_script_imx6q,
> };
>
> +static struct sdma_driver_data sdma_imx6ul = {
> + .chnenbl0 = SDMA_CHNENBL0_IMX35,
> + .num_events = 48,
> + .script_addrs = &sdma_script_imx6q,
> + .ecspi_fixed = true,
> +};
> +
> static struct sdma_script_start_addrs sdma_script_imx7d = {
> .ap_2_ap_addr = 644,
> .uart_2_mcu_addr = 819,
> @@ -629,6 +643,7 @@ static const struct of_device_id sdma_dt_ids[] = {
> { .compatible = "fsl,imx31-sdma", .data = &sdma_imx31, },
> { .compatible = "fsl,imx25-sdma", .data = &sdma_imx25, },
> { .compatible = "fsl,imx7d-sdma", .data = &sdma_imx7d, },
> + { .compatible = "fsl,imx6ul-sdma", .data = &sdma_imx6ul, },
> { .compatible = "fsl,imx8mq-sdma", .data = &sdma_imx8mq, },
> { /* sentinel */ }
> };
> @@ -948,8 +963,15 @@ static void sdma_get_pc(struct sdma_channel *sdmac,
> break;
> case IMX_DMATYPE_CSPI:
> per_2_emi = sdma->script_addrs->app_2_mcu_addr;
> - emi_2_per = sdma->script_addrs->mcu_2_ecspi_addr;
> - sdmac->is_ram_script = true;
> +
> + /* Use rom script mcu_2_app if ERR009165 fixed */
> + if (sdmac->sdma->drvdata->ecspi_fixed) {
> + emi_2_per = sdma->script_addrs->mcu_2_app_addr;
> + } else {
> + emi_2_per = sdma->script_addrs->mcu_2_ecspi_addr;
> + sdmac->is_ram_script = true;
> + }
> +
> break;
> case IMX_DMATYPE_EXT:
> case IMX_DMATYPE_SSI:
next prev parent reply other threads:[~2021-07-14 8:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 10:20 [PATCH v16 00/12] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2021-07-14 9:05 ` Lucas Stach
2021-07-20 12:22 ` Vinod Koul
2021-07-14 10:20 ` [PATCH v16 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2021-07-14 10:20 ` [PATCH v16 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2021-07-14 10:20 ` [PATCH v16 03/12] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2021-07-14 10:20 ` [PATCH v16 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Robin Gong
2021-07-14 10:20 ` [PATCH v16 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Robin Gong
2021-07-14 8:17 ` Lucas Stach
2021-07-14 10:20 ` [PATCH v16 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2021-07-14 10:20 ` [PATCH v16 07/12] spi: imx: fix ERR009165 Robin Gong
2021-07-14 10:20 ` [PATCH v16 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
2021-07-14 10:20 ` [PATCH v16 09/12] dmaengine: imx-sdma: remove ERR009165 " Robin Gong
2021-07-14 8:17 ` Lucas Stach [this message]
2021-07-14 10:20 ` [PATCH v16 10/12] dma: imx-sdma: add i.mx6ul compatible name Robin Gong
2021-07-14 10:20 ` [PATCH v16 11/12] dmaengine: imx-sdma: add uart rom script Robin Gong
2021-07-14 10:20 ` [PATCH v16 12/12] dmaengine: imx-sdma: add terminated list for freed descriptor in worker Robin Gong
2021-07-23 3:20 ` [PATCH v16 00/12] add ecspi ERR009165 for i.mx6/7 soc family Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152cb353c4c6fe66ba40c084cd62947967080011.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=martin.fuzzey@flowbird.group \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
--cc=will.deacon@arm.com \
--cc=xiaoning.wang@nxp.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).