From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,07/15] spi: imx: remove ERR009165 workaround on i.mx6ul From: Lucas Stach Message-Id: <1556269796.2584.25.camel@pengutronix.de> Date: Fri, 26 Apr 2019 11:09:56 +0200 To: Robin Gong , "broonie@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "u.kleine-koenig@pengutronix.de" , "plyatov@gmail.com" , "dan.j.williams@intel.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-ID: QW0gRnJlaXRhZywgZGVuIDI2LjA0LjIwMTksIDA4OjA1ICswMDAwIHNjaHJpZWIgUm9iaW4gR29u ZzoKPiDCoMKgwqBFUlIwMDkxNjUgZml4IG9uIGkubXg2dWwgYW5kIG5leHQgY2hpcCwgc3VjaCBh cyBpLm14NnVsbC9pLm14OG1xL2kubXg4bW0uCj4gUmVtb3ZlIHdvcmthcm91bmQgb24gdGhvc2Ug Y2hpcHMuIEFkZCBuZXcgaS5teDZ1bCB0eXBlIGZvciB0aGF0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFJvYmluIEdvbmcgPHlpYmluLmdvbmdAbnhwLmNvbT4KPiAtLS0KPiDCoGRyaXZlcnMvc3BpL3Nw aS1pbXguYyB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+IMKg MSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvc3BpL3NwaS1pbXguYyBiL2RyaXZlcnMvc3BpL3NwaS1pbXguYwo+ IGluZGV4IGViNTZlYWMuLjJlNWU5NzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9zcGkvc3BpLWlt eC5jCj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLWlteC5jCj4gQEAgLTU3LDYgKzU3LDcgQEAgZW51 bSBzcGlfaW14X2RldnR5cGUgewo+IMKgCUlNWDM1X0NTUEksCS8qIENTUEkgb24gYWxsIGkubXgg ZXhjZXB0IGFib3ZlICovCj4gwqAJSU1YNTFfRUNTUEksCS8qIEVDU1BJIG9uIGkubXg1MSAqLwo+ IMKgCUlNWDUzX0VDU1BJLAkvKiBFQ1NQSSBvbiBpLm14NTMgYW5kIGxhdGVyICovCj4gKwlJTVg2 VUxfRUNTUEksCS8qIEVSUjAwOTE2NSBmaXggZnJvbSBpLm14NnVsICovCj4gwqB9Owo+IMKgCj4g wqBzdHJ1Y3Qgc3BpX2lteF9kYXRhOwo+IEBAIC0xMjgsNyArMTI5LDggQEAgc3RhdGljIGlubGlu ZSBpbnQgaXNfaW14MzVfY3NwaShzdHJ1Y3Qgc3BpX2lteF9kYXRhICpkKQo+IMKgCj4gwqBzdGF0 aWMgaW5saW5lIGludCBpc19pbXg1MV9lY3NwaShzdHJ1Y3Qgc3BpX2lteF9kYXRhICpkKQo+IMKg ewo+IC0JcmV0dXJuIGQtPmRldnR5cGVfZGF0YS0+ZGV2dHlwZSA9PSBJTVg1MV9FQ1NQSTsKPiAr CXJldHVybiBkLT5kZXZ0eXBlX2RhdGEtPmRldnR5cGUgPT0gSU1YNTFfRUNTUEkgfHwKPiArCcKg wqDCoMKgwqDCoMKgZC0+ZGV2dHlwZV9kYXRhLT5kZXZ0eXBlID09IElNWDZVTF9FQ1NQSTsKPiDC oH0KPiDCoAo+IMKgc3RhdGljIGlubGluZSBpbnQgaXNfaW14NTNfZWNzcGkoc3RydWN0IHNwaV9p bXhfZGF0YSAqZCkKPiBAQCAtNTg1LDkgKzU4NywxNiBAQCBzdGF0aWMgaW50IG14NTFfZWNzcGlf cHJlcGFyZV90cmFuc2ZlcihzdHJ1Y3Qgc3BpX2lteF9kYXRhICpzcGlfaW14LAo+IMKgCWN0cmwg fD0gbXg1MV9lY3NwaV9jbGtkaXYoc3BpX2lteCwgdC0+c3BlZWRfaHosICZjbGspOwo+IMKgCXNw aV9pbXgtPnNwaV9idXNfY2xrID0gY2xrOwo+IMKgCj4gLQkvKiBFUlIwMDkxNjU6IHdvcmsgaW4g WEhDIG1vZGUgYXMgUElPICovCj4gLQlpZiAoc3BpX2lteC0+dXNlZG1hKQo+IC0JCWN0cmwgJj0g fk1YNTFfRUNTUElfQ1RSTF9TTUM7Cj4gKwkvKgo+ICsJwqAqIEVSUjAwOTE2NTogd29yayBpbiBY SEMgbW9kZSBpbnN0ZWFkIG9mIFNNQyBhcyBQSU8gb24gdGhlIGNoaXBzCj4gKwnCoCogYmVmb3Jl IGkubXg2dWwuCj4gKwnCoCovCj4gKwlpZiAoc3BpX2lteC0+dXNlZG1hKSB7Cj4gKwkJaWYgKHNw aV9pbXgtPmRldnR5cGVfZGF0YS0+ZGV2dHlwZSA9PSBJTVg2VUxfRUNTUEkpCgo+PSwgb3RoZXJ3 aXNlIHRoZSB3b3JrYXJvdW5kIG1pZ2h0IGJlIGFwcGxpZWQgdG8gbGF0ZXIgZ2VuZXJhdGlvbnMg b2YKdGhlIGNvcmUgaWYgbW9yZSBhcmUgYWRkZWQgbGF0ZXIuCgpSZWdhcmRzLApMdWNhcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09E4C43218 for ; Fri, 26 Apr 2019 09:10:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B87E20675 for ; Fri, 26 Apr 2019 09:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725959AbfDZJKL (ORCPT ); Fri, 26 Apr 2019 05:10:11 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:54509 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbfDZJKK (ORCPT ); Fri, 26 Apr 2019 05:10:10 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1hJwrm-0000LO-0y; Fri, 26 Apr 2019 11:09:58 +0200 Message-ID: <1556269796.2584.25.camel@pengutronix.de> Subject: Re: [PATCH v2 07/15] spi: imx: remove ERR009165 workaround on i.mx6ul From: Lucas Stach To: Robin Gong , "broonie@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "u.kleine-koenig@pengutronix.de" , "plyatov@gmail.com" , "dan.j.williams@intel.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Date: Fri, 26 Apr 2019 11:09:56 +0200 In-Reply-To: <1556265512-9130-8-git-send-email-yibin.gong@nxp.com> References: <1556265512-9130-1-git-send-email-yibin.gong@nxp.com> <1556265512-9130-8-git-send-email-yibin.gong@nxp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Message-ID: <20190426090956.nXpaWbhml0wpCndhPbx3EGY5S_Ua5g_6a-Af25jXR7c@z> Am Freitag, den 26.04.2019, 08:05 +0000 schrieb Robin Gong: >    ERR009165 fix on i.mx6ul and next chip, such as i.mx6ull/i.mx8mq/i.mx8mm. > Remove workaround on those chips. Add new i.mx6ul type for that. > > Signed-off-by: Robin Gong > --- >  drivers/spi/spi-imx.c | 39 +++++++++++++++++++++++++++++++++++---- >  1 file changed, 35 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c > index eb56eac..2e5e978 100644 > --- a/drivers/spi/spi-imx.c > +++ b/drivers/spi/spi-imx.c > @@ -57,6 +57,7 @@ enum spi_imx_devtype { >   IMX35_CSPI, /* CSPI on all i.mx except above */ >   IMX51_ECSPI, /* ECSPI on i.mx51 */ >   IMX53_ECSPI, /* ECSPI on i.mx53 and later */ > + IMX6UL_ECSPI, /* ERR009165 fix from i.mx6ul */ >  }; >   >  struct spi_imx_data; > @@ -128,7 +129,8 @@ static inline int is_imx35_cspi(struct spi_imx_data *d) >   >  static inline int is_imx51_ecspi(struct spi_imx_data *d) >  { > - return d->devtype_data->devtype == IMX51_ECSPI; > + return d->devtype_data->devtype == IMX51_ECSPI || > +        d->devtype_data->devtype == IMX6UL_ECSPI; >  } >   >  static inline int is_imx53_ecspi(struct spi_imx_data *d) > @@ -585,9 +587,16 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx, >   ctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, &clk); >   spi_imx->spi_bus_clk = clk; >   > - /* ERR009165: work in XHC mode as PIO */ > - if (spi_imx->usedma) > - ctrl &= ~MX51_ECSPI_CTRL_SMC; > + /* > +  * ERR009165: work in XHC mode instead of SMC as PIO on the chips > +  * before i.mx6ul. > +  */ > + if (spi_imx->usedma) { > + if (spi_imx->devtype_data->devtype == IMX6UL_ECSPI) >=, otherwise the workaround might be applied to later generations of the core if more are added later. Regards, Lucas