From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E563C3A59C for ; Fri, 16 Aug 2019 06:56:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD058206C1 for ; Fri, 16 Aug 2019 06:56:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725971AbfHPG4Z (ORCPT ); Fri, 16 Aug 2019 02:56:25 -0400 Received: from mail-yb1-f194.google.com ([209.85.219.194]:39649 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfHPG4Z (ORCPT ); Fri, 16 Aug 2019 02:56:25 -0400 Received: by mail-yb1-f194.google.com with SMTP id s142so1654571ybc.6; Thu, 15 Aug 2019 23:56:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4ztm7/zVpVkuXSHNsVBdpX0tZryq84sGebRCqDN6Oec=; b=hx6jhblNg9LydZ/U24XFVjMR70NOyb11+aLRqUxCEi03E6fDjEK+TV5PSm26Vq2rkG cozbT48eiJFf4/nyGKhi8Phd8Vi+nOC7yVyMfXPK6kiPZzAXrteoZslp7xOYF6K+PgGZ Lq60PTACwaRFhoU7phlh+bKLMKkT7cCrhYI6P62+Y2g6QK6xTzbfbSDoezs+TAifgHs6 T2nOAK/tiLPHtdh0Xm4g1rI8SxVxd/rbmjTMLAzATZ7iivmQTQGtQqXLUcVV8pzQwdsU lvxBrNDx3/EWV4f1TkEXjTxXfQqUdy5oFys/J8jyHZoQa+vCisLUkn852/SWCLXOiWlz 262w== X-Gm-Message-State: APjAAAWXAeuLs9NNUmbbYqsEd/GTG20fQKqgkjfIlg9R8eyMLI9tZh1z hsHVbqjHHHoBRZAxOUN+Asc= X-Google-Smtp-Source: APXvYqzqTXvd0kb83aAhFrkE+7i2v5nGMBvGmG5Qy7Gq01EuafDOOHKK7E2mK/UYebijbK/PpjXX8A== X-Received: by 2002:a25:7057:: with SMTP id l84mr6026642ybc.340.1565938584444; Thu, 15 Aug 2019 23:56:24 -0700 (PDT) Received: from localhost.localdomain (24-158-240-219.dhcp.smyr.ga.charter.com. [24.158.240.219]) by smtp.gmail.com with ESMTPSA id v203sm1099740ywa.99.2019.08.15.23.56.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Aug 2019 23:56:23 -0700 (PDT) From: Wenwen Wang To: Wenwen Wang Cc: Vinod Koul , Dan Williams , Enrico Weigelt , Allison Randal , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , dmaengine@vger.kernel.org (open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe() Date: Fri, 16 Aug 2019 01:56:08 -0500 Message-Id: <1565938570-7528-1-git-send-email-wenwen@cs.uga.edu> X-Mailer: git-send-email 2.7.4 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org If devm_request_irq() fails to disable all interrupts, no cleanup is performed before retuning the error. To fix this issue, invoke omap_dma_free() to do the cleanup. Signed-off-by: Wenwen Wang --- drivers/dma/ti/omap-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c index ba2489d..5158b58 100644 --- a/drivers/dma/ti/omap-dma.c +++ b/drivers/dma/ti/omap-dma.c @@ -1540,8 +1540,10 @@ static int omap_dma_probe(struct platform_device *pdev) rc = devm_request_irq(&pdev->dev, irq, omap_dma_irq, IRQF_SHARED, "omap-dma-engine", od); - if (rc) + if (rc) { + omap_dma_free(od); return rc; + } } if (omap_dma_glbl_read(od, CAPS_0) & CAPS_0_SUPPORT_LL123) -- 2.7.4