From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> To: vkoul@kernel.org, dan.j.williams@intel.com, michal.simek@xilinx.com, nick.graumann@gmail.com, andrea.merello@gmail.com, appana.durga.rao@xilinx.com, mcgrof@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> Subject: [PATCH -next 5/8] dmaengine: xilinx_dma: Remove residue from channel data Date: Thu, 5 Sep 2019 22:07:01 +0530 Message-ID: <1567701424-25658-6-git-send-email-radhey.shyam.pandey@xilinx.com> (raw) In-Reply-To: <1567701424-25658-1-git-send-email-radhey.shyam.pandey@xilinx.com> From: Nicholas Graumann <nick.graumann@gmail.com> Now that we track residues for each descriptor, there is no need to keep track of the residue for each channel. Signed-off-by: Nicholas Graumann <nick.graumann@gmail.com> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> --- drivers/dma/xilinx/xilinx_dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 3f2e0ad..bf3fa2e 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -340,7 +340,6 @@ struct xilinx_dma_tx_descriptor { * @desc_pendingcount: Descriptor pending count * @ext_addr: Indicates 64 bit addressing is supported by dma channel * @desc_submitcount: Descriptor h/w submitted count - * @residue: Residue for AXI DMA * @seg_v: Statically allocated segments base * @seg_p: Physical allocated segments base * @cyclic_seg_v: Statically allocated segment base for cyclic transfers @@ -377,7 +376,6 @@ struct xilinx_dma_chan { u32 desc_pendingcount; bool ext_addr; u32 desc_submitcount; - u32 residue; struct xilinx_axidma_tx_segment *seg_v; dma_addr_t seg_p; struct xilinx_axidma_tx_segment *cyclic_seg_v; @@ -1068,11 +1066,11 @@ static enum dma_status xilinx_dma_tx_status(struct dma_chan *dchan, desc = list_last_entry(&chan->active_list, struct xilinx_dma_tx_descriptor, node); - chan->residue = xilinx_dma_get_residue(chan, desc); + desc->residue = xilinx_dma_get_residue(chan, desc); spin_unlock_irqrestore(&chan->lock, flags); - dma_set_residue(txstate, chan->residue); + dma_set_residue(txstate, desc->residue); return ret; } -- 2.7.4
next prev parent reply index Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-05 16:36 [PATCH -next 0/8] AXI DMA driver improvements Radhey Shyam Pandey 2019-09-05 16:36 ` [PATCH -next 1/8] dmaengine: xilinx_dma: Remove desc_callback_valid check Radhey Shyam Pandey 2019-09-05 16:36 ` [PATCH -next 2/8] dmaengine: xilinx_dma: Merge get_callback and _invoke Radhey Shyam Pandey 2019-09-05 16:36 ` [PATCH -next 3/8] dmaengine: xilinx_dma: Introduce xilinx_dma_get_residue Radhey Shyam Pandey 2019-09-25 21:01 ` Vinod Koul 2019-09-26 5:52 ` Radhey Shyam Pandey 2019-09-26 17:18 ` Vinod Koul 2019-09-27 5:16 ` Radhey Shyam Pandey 2019-10-01 12:03 ` Radhey Shyam Pandey 2019-09-05 16:37 ` [PATCH -next 4/8] dmaengine: xilinx_dma: Add callback_result support Radhey Shyam Pandey 2019-09-05 16:37 ` Radhey Shyam Pandey [this message] 2019-09-05 16:37 ` [PATCH -next 6/8] dmaengine: xilinx_dma: Print debug message when no free tx segments Radhey Shyam Pandey 2019-09-05 16:37 ` [PATCH -next 7/8] dmaengine: xilinx_dma: Check for both idle and halted state in axidma stop_transfer Radhey Shyam Pandey 2019-09-26 17:21 ` Vinod Koul 2019-09-27 6:48 ` Radhey Shyam Pandey 2019-09-27 13:57 ` Nicholas Graumann 2019-09-27 16:53 ` Radhey Shyam Pandey 2019-09-05 16:37 ` [PATCH -next 8/8] dmaengine: xilinx_dma: Clear desc_pendingcount in xilinx_dma_reset Radhey Shyam Pandey
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1567701424-25658-6-git-send-email-radhey.shyam.pandey@xilinx.com \ --to=radhey.shyam.pandey@xilinx.com \ --cc=andrea.merello@gmail.com \ --cc=appana.durga.rao@xilinx.com \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mcgrof@kernel.org \ --cc=michal.simek@xilinx.com \ --cc=nick.graumann@gmail.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
dmaengine Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \ dmaengine@vger.kernel.org public-inbox-index dmaengine Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine AGPL code for this site: git clone https://public-inbox.org/public-inbox.git