From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DFDC432C1 for ; Tue, 24 Sep 2019 19:32:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A99E214DA for ; Tue, 24 Sep 2019 19:32:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="jW0lrNqJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390640AbfIXTcz (ORCPT ); Tue, 24 Sep 2019 15:32:55 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:50500 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388207AbfIXTcz (ORCPT ); Tue, 24 Sep 2019 15:32:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1569353572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KlcrFKHqRHEWTZwgwOrmjPoSAcprqpYblaKBY9ljXVE=; b=jW0lrNqJ9kfs3VLCQGkvbq0bjx2lK5xC4x7irzyPUAKayRIgQdwstRK5YwCHoHCVh/yN22 KzC25U3qxCJg6MTPZyi2E1r2I3kSKh/DarsAfhK7LNaJjRqTvGGBkCeOJ6FAh6ZIiMtNSJ TBC49rH918ZFJ0rEjFkUaLSDhZbwB0o= Date: Tue, 24 Sep 2019 21:32:32 +0200 From: Paul Cercueil Subject: Re: [PATCH] dmaengine: jz4780: Use devm_platform_ioremap_resource() in jz4780_dma_probe() To: Markus Elfring Cc: dmaengine@vger.kernel.org, Dan Williams , Vinod Koul , Zubair Lutfullah Kakakhel , LKML , kernel-janitors@vger.kernel.org, Alex Smith Message-Id: <1569353552.1911.0@crapouillou.net> In-Reply-To: <5dd19f28-349a-4957-ea3a-6aebbd7c97e2@web.de> References: <5dd19f28-349a-4957-ea3a-6aebbd7c97e2@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Markus, Le dim. 22 sept. 2019 =E0 11:25, Markus Elfring =20 a =E9crit : > From: Markus Elfring > Date: Sun, 22 Sep 2019 11:18:27 +0200 >=20 > Simplify this function implementation a bit by using > a known wrapper function. >=20 > This issue was detected by using the Coccinelle software. >=20 > Signed-off-by: Markus Elfring Looks good to me. Signed-off-by: Paul Cercueil > --- > drivers/dma/dma-jz4780.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) >=20 > diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c > index cafb1cc065bb..f42b3ef8e036 100644 > --- a/drivers/dma/dma-jz4780.c > +++ b/drivers/dma/dma-jz4780.c > @@ -858,13 +858,7 @@ static int jz4780_dma_probe(struct=20 > platform_device *pdev) > jzdma->soc_data =3D soc_data; > platform_set_drvdata(pdev, jzdma); >=20 > - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(dev, "failed to get I/O memory\n"); > - return -EINVAL; > - } > - > - jzdma->chn_base =3D devm_ioremap_resource(dev, res); > + jzdma->chn_base =3D devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(jzdma->chn_base)) > return PTR_ERR(jzdma->chn_base); >=20 > -- > 2.23.0 >=20 =