From: Paul Cercueil <paul@crapouillou.net>
To: Zhou Yanjie <zhouyanjie@zoho.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, paul.burton@mips.com, vkoul@kernel.org,
mark.rutland@arm.com, Zubair.Kakakhel@imgtec.com,
dan.j.williams@intel.com
Subject: Re: [PATCH RESEND 2/2] dmaengine: JZ4780: Add support for the X1000.
Date: Wed, 23 Oct 2019 18:08:21 +0200 [thread overview]
Message-ID: <1571846901.3.0@crapouillou.net> (raw)
In-Reply-To: <1571814137-46002-3-git-send-email-zhouyanjie@zoho.com>
Hi Zhou,
Le mer., oct. 23, 2019 at 15:02, Zhou Yanjie <zhouyanjie@zoho.com> a
écrit :
> Add support for probing the dma-jz4780 driver on the X1000 Soc.
>
> Signed-off-by: Zhou Yanjie <zhouyanjie@zoho.com>
> ---
> drivers/dma/dma-jz4780.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index cafb1cc0..f809a6e 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -1019,11 +1019,18 @@ static const struct jz4780_dma_soc_data
> jz4780_dma_soc_data = {
> .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA,
> };
>
> +static const struct jz4780_dma_soc_data x1000_dma_soc_data = {
> + .nb_channels = 8,
> + .transfer_ord_max = 7,
> + .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA,
Please don't use JZ_SOC_DATA_ALLOW_LEGACY_DT for new bindings.
With that flag removed:
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
> +};
> +
> static const struct of_device_id jz4780_dma_dt_match[] = {
> { .compatible = "ingenic,jz4740-dma", .data = &jz4740_dma_soc_data
> },
> { .compatible = "ingenic,jz4725b-dma", .data =
> &jz4725b_dma_soc_data },
> { .compatible = "ingenic,jz4770-dma", .data = &jz4770_dma_soc_data
> },
> { .compatible = "ingenic,jz4780-dma", .data = &jz4780_dma_soc_data
> },
> + { .compatible = "ingenic,x1000-dma", .data = &x1000_dma_soc_data },
> {},
> };
> MODULE_DEVICE_TABLE(of, jz4780_dma_dt_match);
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2019-10-23 16:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 3:05 DMA: JZ4780: Add DMA driver for X1000 Zhou Yanjie
2019-10-23 3:05 ` [PATCH 1/2] dt-bindings: DMA: Add X1000 bindings Zhou Yanjie
2019-10-23 3:05 ` [PATCH 2/2] DMA: JZ4780: Add support for the X1000 Zhou Yanjie
2019-10-23 5:15 ` DMA: JZ4780: Add DMA driver for X1000 Vinod Koul
2019-10-23 7:05 ` Zhou Yanjie
2019-10-23 7:02 ` dmaengine: JZ4780: Add dmaengine " Zhou Yanjie
2019-10-23 7:02 ` [PATCH RESEND 1/2] dt-bindings: dmaengine: Add X1000 bindings Zhou Yanjie
2019-10-23 7:02 ` [PATCH RESEND 2/2] dmaengine: JZ4780: Add support for the X1000 Zhou Yanjie
2019-10-23 16:08 ` Paul Cercueil [this message]
2019-10-24 8:32 ` Zhou Yanjie
2019-10-24 17:21 ` dmaengine: JZ4780: Add support for the X1000 v2 Zhou Yanjie
2019-10-24 17:21 ` [PATCH 1/2 v2] dt-bindings: dmaengine: Add X1000 bindings Zhou Yanjie
2019-10-29 21:35 ` Rob Herring
2019-10-24 17:21 ` [PATCH 2/2 v2] dmaengine: JZ4780: Add support for the X1000 Zhou Yanjie
2019-11-06 17:11 ` dmaengine: JZ4780: Add support for the X1000 v2 Vinod Koul
2019-11-08 18:51 ` Zhou Yanjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571846901.3.0@crapouillou.net \
--to=paul@crapouillou.net \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul.burton@mips.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=zhouyanjie@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).