From: Paul Cercueil <paul@crapouillou.net>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove
Date: Tue, 05 Nov 2019 10:01:12 +0100 [thread overview]
Message-ID: <1572944472.3.0@crapouillou.net> (raw)
In-Reply-To: <20191104161622.11758-1-hslester96@gmail.com>
Hi,
Le mar., nov. 5, 2019 at 00:16, Chuhong Yuan <hslester96@gmail.com> a
écrit :
> The remove misses to disable and unprepare jzdma->clk.
> Add a call to clk_disable_unprepare to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Thanks.
> ---
> drivers/dma/dma-jz4780.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index cafb1cc065bb..66ab76b9520f 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -987,6 +987,7 @@ static int jz4780_dma_remove(struct
> platform_device *pdev)
>
> of_dma_controller_free(pdev->dev.of_node);
>
> + clk_disable_unprepare(jzdma->clk);
> free_irq(jzdma->irq, jzdma);
>
> for (i = 0; i < jzdma->soc_data->nb_channels; i++)
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-11-05 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 16:16 [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove Chuhong Yuan
2019-11-05 9:01 ` Paul Cercueil [this message]
2019-11-08 3:54 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572944472.3.0@crapouillou.net \
--to=paul@crapouillou.net \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).