From: Dave Jiang <dave.jiang@intel.com>
To: vkoul@kernel.org
Cc: Dan Williams <dan.j.williams@intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
dmaengine@vger.kernel.org, dan.carpenter@oracle.com
Subject: [PATCH v8 0/8] idxd 'struct device' lifetime handling fixes
Date: Thu, 25 Mar 2021 08:54:31 -0700 [thread overview]
Message-ID: <161668743322.2670112.2302120522403482843.stgit@djiang5-desk3.ch.intel.com> (raw)
v8:
- Do not emit negative value for sysfs 'minor' attrib (Dan)
- Use sysfs_emit() to emit sysfs 'minor' attrib (Jason)
- Fix interation of unwind cleanup of various allocation. (DanC)
v7:
- Fix up the 'struct device' setup in char device code (Jason)
- Split out the char dev fixes (Jason)
- Split out the DMA dev fixes (Dan)
- Split out the each of the conf_dev fixes
- Split out removal of the pcim_* calls
- Split out removal of the devm_* calls
- Split out the fixes for interrupt config calls
- Reviewed by Dan.
v6:
- Fix char dev initialization issues (Jason)
- Fix other 'struct device' initialization issues.
v5:
- Rebased against 5.12-rc dmaengine/fixes
v4:
- fix up the life time of cdev creation/destruction (Jason)
- Tested with KASAN and other memory allocation leak detections. (Jason)
v3:
- Remove devm_* for irq request and cleanup related bits (Jason)
v2:
- Remove all devm_* alloc for idxd_device (Jason)
- Add kref dep for dma_dev (Jason)
Vinod,
The series fixes the various 'struct device' lifetime handling in the
idxd driver. The devm managed lifetime is incompatible with 'struct device'
objects that resides in the idxd context. Tested with
CONFIG_DEBUG_KOBJECT_RELEASE and address all issues from that.
Please consider for damengine/fixes for the 5.12-rc.
---
Dave Jiang (8):
dmaengine: idxd: fix dma device lifetime
dmaengine: idxd: cleanup pci interrupt vector allocation management
dmaengine: idxd: removal of pcim managed mmio mapping
dmaengine: idxd: fix idxd conf_dev 'struct device' lifetime
dmaengine: idxd: fix wq conf_dev 'struct device' lifetime
dmaengine: idxd: fix engine conf_dev lifetime
dmaengine: idxd: fix group conf_dev lifetime
dmaengine: idxd: fix cdev setup and free device lifetime issues
drivers/dma/idxd/cdev.c | 131 +++++++-----------
drivers/dma/idxd/device.c | 20 +--
drivers/dma/idxd/idxd.h | 54 ++++++--
drivers/dma/idxd/init.c | 284 +++++++++++++++++++++++++++-----------
drivers/dma/idxd/irq.c | 10 +-
drivers/dma/idxd/sysfs.c | 241 ++++++++++++++++----------------
6 files changed, 439 insertions(+), 301 deletions(-)
--
next reply other threads:[~2021-03-25 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 15:54 Dave Jiang [this message]
2021-03-25 15:54 ` [PATCH v8 1/8] dmaengine: idxd: fix dma device lifetime Dave Jiang
2021-03-25 15:54 ` [PATCH v8 2/8] dmaengine: idxd: cleanup pci interrupt vector allocation management Dave Jiang
2021-03-25 15:54 ` [PATCH v8 3/8] dmaengine: idxd: removal of pcim managed mmio mapping Dave Jiang
2021-03-25 15:54 ` [PATCH v8 4/8] dmaengine: idxd: fix idxd conf_dev 'struct device' lifetime Dave Jiang
2021-03-25 15:55 ` [PATCH v8 5/8] dmaengine: idxd: fix wq " Dave Jiang
2021-03-30 17:36 ` Jason Gunthorpe
2021-03-25 15:55 ` [PATCH v8 6/8] dmaengine: idxd: fix engine conf_dev lifetime Dave Jiang
2021-03-25 15:55 ` [PATCH v8 7/8] dmaengine: idxd: fix group " Dave Jiang
2021-03-25 15:55 ` [PATCH v8 8/8] dmaengine: idxd: fix cdev setup and free device lifetime issues Dave Jiang
2021-03-30 17:45 ` [PATCH v8 0/8] idxd 'struct device' lifetime handling fixes Jason Gunthorpe
2021-03-30 17:58 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161668743322.2670112.2302120522403482843.stgit@djiang5-desk3.ch.intel.com \
--to=dave.jiang@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jgg@nvidia.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).